2022-12-28 01:27:12 -08:00
|
|
|
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
|
|
#
|
|
|
|
# This source code is licensed under the MIT license found in the
|
|
|
|
# LICENSE file in the root directory of this source tree.
|
|
|
|
|
2023-05-15 15:21:56 -07:00
|
|
|
cmake_minimum_required(VERSION 3.13...3.26)
|
2022-12-28 01:27:12 -08:00
|
|
|
set(CMAKE_VERBOSE_MAKEFILE on)
|
|
|
|
project(yoga)
|
|
|
|
|
2023-01-16 07:56:11 -08:00
|
|
|
file(GLOB SOURCES CONFIGURE_DEPENDS
|
2022-12-28 01:27:12 -08:00
|
|
|
${CMAKE_CURRENT_SOURCE_DIR}/../yoga/*.cpp
|
|
|
|
${CMAKE_CURRENT_SOURCE_DIR}/../yoga/**/*.cpp
|
2023-05-09 15:35:42 -07:00
|
|
|
${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp)
|
2022-12-28 01:27:12 -08:00
|
|
|
|
|
|
|
include_directories(..)
|
|
|
|
|
Breaking: Use C++ 20 (#1382)
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1382
X-link: https://github.com/facebook/react-native/pull/39437
Have been running into places where C++ 20 makes life easier for use like `std::bit_cast` (that one is easy to polyfill), in-class member initializer support for bitfields, designated initializers, defaulted comparison operator, concepts instead of SFINAE, and probably more.
Our other infra is in the process of making this jump, or already has. This tests it out everywhere, across the various reference builds, to see if we have any issues.
This is a bit more aggressive than I had previously communicated, but n - 1 is going to be a better long term place than n - 2.
If we wanted to use `std::bit_cast` we would need one of:
1. GCC 11+ (~2.5 years old)
1. Clang 14 (~2.5 years old)
1. VS 16.11 (~2 years old)
For mobile this means:
1. NDK 26 (still in Beta 😭)
1. XCode 14.3.0 (~6 months old)
https://en.cppreference.com/w/cpp/compiler_support/20
That isn't quite doable yet, but we can start taking advantage of language features in the meantime. More of these will be supported in older toolchains.
Anyone needing support for older C++ versions can lag behind on more recent changes. E.g. Yoga 2.0 supports C++ 14.
bypass-github-export-checks
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D49261607
fbshipit-source-id: ceb06eac20dfe93352d7b796d6847a7314069cf3
2023-09-19 01:28:35 -07:00
|
|
|
set(CMAKE_CXX_STANDARD 20)
|
2022-12-28 01:27:12 -08:00
|
|
|
|
|
|
|
add_compile_definitions(
|
|
|
|
EMSCRIPTEN_HAS_UNBOUND_TYPE_NAMES=0)
|
|
|
|
|
|
|
|
set(COMPILE_OPTIONS
|
|
|
|
-flto
|
|
|
|
-fno-exceptions
|
|
|
|
-fno-rtti
|
|
|
|
-g0
|
|
|
|
-Os
|
|
|
|
"SHELL:-s STRICT=1")
|
|
|
|
|
|
|
|
add_compile_options(${COMPILE_OPTIONS})
|
|
|
|
|
|
|
|
add_link_options(
|
|
|
|
${COMPILE_OPTIONS}
|
Consolidate JavaScript Flavors (#1433)
Summary:
Fixes https://github.com/facebook/yoga/issues/1417
This dramatically simplifies the matrix of Node vs web, ASM vs WASM, sync vs async compilation, or CommonJS vs ES Modules. We have one variant, using wasm, with ESModule top-level await to do async compilation. Web/node share the same binary, and we base64 encode the WASM into a wrapper JS file for compatibility with Node and bundlers.
This has some downsides, like requiring an environment with top level await, but also has upsides, like a consistent, sync looking API compatible with older Yoga, and mitigating TypeScript issues with package exports and typings resolution.
As part of this work I also removed `ts-node` from the toolchain (at the cost of a couple of config files needing to be vanilla JS).
Pull Request resolved: https://github.com/facebook/yoga/pull/1433
Test Plan:
1. `yarn test`
2. `yarn lint`
3. `yarn tsc`
4. `yarn benchmark`
5. `yarn build` website-next
6. `yarn lint` website-next
7. Locally test website-next
8. Examine package artifact created by GitHub
9. All Automation passes
Reviewed By: yungsters
Differential Revision: D50453324
Pulled By: NickGerleman
fbshipit-source-id: fe1192acc69e57fa69a1ff056dd7b5844d2198d5
2023-10-31 20:41:38 -07:00
|
|
|
"SHELL:--closure 1"
|
|
|
|
"SHELL:--memory-init-file 0"
|
|
|
|
"SHELL:--no-entry"
|
2022-12-28 01:27:12 -08:00
|
|
|
"SHELL:-s ALLOW_MEMORY_GROWTH=1"
|
|
|
|
"SHELL:-s ASSERTIONS=0"
|
|
|
|
"SHELL:-s DYNAMIC_EXECUTION=0"
|
|
|
|
"SHELL:-s EXPORT_NAME='loadYoga'"
|
|
|
|
"SHELL:-s FETCH_SUPPORT_INDEXEDDB=0"
|
|
|
|
"SHELL:-s FILESYSTEM=0"
|
|
|
|
"SHELL:-s MALLOC='emmalloc'"
|
|
|
|
"SHELL:-s MODULARIZE=1"
|
Consolidate JavaScript Flavors (#1433)
Summary:
Fixes https://github.com/facebook/yoga/issues/1417
This dramatically simplifies the matrix of Node vs web, ASM vs WASM, sync vs async compilation, or CommonJS vs ES Modules. We have one variant, using wasm, with ESModule top-level await to do async compilation. Web/node share the same binary, and we base64 encode the WASM into a wrapper JS file for compatibility with Node and bundlers.
This has some downsides, like requiring an environment with top level await, but also has upsides, like a consistent, sync looking API compatible with older Yoga, and mitigating TypeScript issues with package exports and typings resolution.
As part of this work I also removed `ts-node` from the toolchain (at the cost of a couple of config files needing to be vanilla JS).
Pull Request resolved: https://github.com/facebook/yoga/pull/1433
Test Plan:
1. `yarn test`
2. `yarn lint`
3. `yarn tsc`
4. `yarn benchmark`
5. `yarn build` website-next
6. `yarn lint` website-next
7. Locally test website-next
8. Examine package artifact created by GitHub
9. All Automation passes
Reviewed By: yungsters
Differential Revision: D50453324
Pulled By: NickGerleman
fbshipit-source-id: fe1192acc69e57fa69a1ff056dd7b5844d2198d5
2023-10-31 20:41:38 -07:00
|
|
|
"SHELL:-s EXPORT_ES6=1"
|
|
|
|
"SHELL:-s WASM=1"
|
2023-12-12 09:06:58 -08:00
|
|
|
"SHELL:-s TEXTDECODER=0"
|
|
|
|
# SINGLE_FILE=1 combined with ENVIRONMENT='web' creates code that works on
|
|
|
|
# both bundlders and Node.
|
|
|
|
"SHELL:-s SINGLE_FILE=1"
|
|
|
|
"SHELL:-s ENVIRONMENT='web'")
|
2022-12-28 01:27:12 -08:00
|
|
|
|
|
|
|
link_libraries(embind)
|
|
|
|
|
|
|
|
add_library(yogaObjLib OBJECT ${SOURCES})
|
|
|
|
|
2023-05-09 22:21:01 -07:00
|
|
|
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/binaries)
|
2022-12-28 01:27:12 -08:00
|
|
|
|
2023-12-12 09:06:58 -08:00
|
|
|
add_executable(yoga-wasm-base64-esm $<TARGET_OBJECTS:yogaObjLib>)
|