Explicit C++ toolchain on ubuntu-latest
(#1334)
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1334 Last change made me discover CMake on Ubuntu defaults to GCC. This change makes it so that we explicitly configure whether to use Clang/LLVM or GCC when building on machines with the `ubuntu-latest` image. Reviewed By: christophpurrer Differential Revision: D47462132 fbshipit-source-id: e81fb6d4b1740ab2913d39b6e90c52d674e5a4f2
This commit is contained in:
committed by
Facebook GitHub Bot
parent
61bf4d15ab
commit
05b2edfb85
16
.github/workflows/validate-cpp.yml
vendored
16
.github/workflows/validate-cpp.yml
vendored
@@ -12,34 +12,38 @@ env:
|
||||
|
||||
jobs:
|
||||
test:
|
||||
name: Build and Test [${{ matrix.os }}][${{ matrix.mode }}]
|
||||
runs-on: ${{ matrix.os }}
|
||||
name: Build and Test [${{ matrix.toolchain }}][${{ matrix.mode }}]
|
||||
runs-on: ${{ (matrix.toolchain == 'MSVC') && 'windows-latest' || 'ubuntu-latest' }}
|
||||
strategy:
|
||||
matrix:
|
||||
mode: [Debug, Release]
|
||||
os: [ubuntu-latest] # TODO: fix issues building GTest Binary with MSVC in GitHub Actions
|
||||
toolchain: [Clang, GCC] # TODO: fix issues building GTest Binary with MSVC in GitHub Actions
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
|
||||
- name: Setup
|
||||
uses: ./.github/actions/setup-cpp
|
||||
with:
|
||||
toolchain: ${{ matrix.toolchain }}
|
||||
|
||||
- name: Unit tests
|
||||
run: ./unit_tests ${{ matrix.mode }}
|
||||
|
||||
benchmark:
|
||||
name: Benchmark [${{ matrix.os }}]
|
||||
runs-on: ${{ matrix.os }}
|
||||
name: Benchmark [${{ matrix.toolchain }}]
|
||||
runs-on: ${{ (matrix.toolchain == 'MSVC') && 'windows-latest' || 'ubuntu-latest' }}
|
||||
strategy:
|
||||
matrix:
|
||||
os: [ubuntu-latest, windows-latest]
|
||||
toolchain: [Clang, GCC, MSVC]
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
|
||||
- name: Setup
|
||||
uses: ./.github/actions/setup-cpp
|
||||
with:
|
||||
toolchain: ${{ matrix.toolchain }}
|
||||
|
||||
- name: Build benchmark
|
||||
run: |
|
||||
|
Reference in New Issue
Block a user