DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Move default spacing out of csslayout

Browse Source 
Summary: The concept of default padding was confusing and only used by react-native android. Makes more sense to let them manage this themselve.

Reviewed By: foghina

Differential Revision: D3709574

fbshipit-source-id: 6e0277bd97407a5c642d742f93ca2ac70d7307da
This commit is contained in:
Emil Sjolander
2016-08-18 03:15:51 -07:00
committed by Facebook Github Bot 2
parent 9d34b4e110
commit 0672f5572f
5 changed files with 13 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/com/facebook/csslayout/CSSStyle.java
View File

@@ -30,7 +30,7 @@ public class CSSStyle {
public Spacing margin = new Spacing();
public Spacing padding = new Spacing();
public Spacing border = new Spacing();
public Spacing position = new Spacing();
public Spacing position = new Spacing(CSSConstants.UNDEFINED);
public float[] dimensions = new float[2];
@@ -61,13 +61,6 @@ public class CSSStyle {
border.reset();
position.reset();
position.setDefault(Spacing.LEFT, CSSConstants.UNDEFINED);
position.setDefault(Spacing.RIGHT, CSSConstants.UNDEFINED);
position.setDefault(Spacing.TOP, CSSConstants.UNDEFINED);
position.setDefault(Spacing.BOTTOM, CSSConstants.UNDEFINED);
position.setDefault(Spacing.START, CSSConstants.UNDEFINED);
position.setDefault(Spacing.END, CSSConstants.UNDEFINED);
Arrays.fill(dimensions, CSSConstants.UNDEFINED);
minWidth = CSSConstants.UNDEFINED;