DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove force_static

Browse Source 
Summary: static linking is dangerous here as more than one library could be including the same symbols. The used to only be used by the jni target previously but that is no longer true

Reviewed By: gkassabli

Differential Revision: D4258293

fbshipit-source-id: 053f9e607503707830e3766b1f268ab31d3081ff
This commit is contained in:
Emil Sjolander
2016-12-02 05:08:57 -08:00
committed by Facebook Github Bot
parent 686289814d
commit 07cf47baad
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
BUCK
View File

@@ -29,9 +29,10 @@ cxx_library(
tests=[':tests'], tests=[':tests'],
exported_headers = subdir_glob([('', 'CSSLayout/*.h')]), exported_headers = subdir_glob([('', 'CSSLayout/*.h')]),
header_namespace = '', header_namespace = '',
force_static = True,
compiler_flags = COMPILER_FLAGS, compiler_flags = COMPILER_FLAGS,
deps = [], deps = [] if THIS_IS_FBOBJC else [
csslayout_dep('lib/fb:ndklog'),
],
visibility = ['PUBLIC'], visibility = ['PUBLIC'],
) )

3
YOGA_DEFS
View File

@@ -9,7 +9,10 @@ GTEST_TARGET = '//lib/gtest:gtest'
JNI_TARGET = '//lib/jni:jni' JNI_TARGET = '//lib/jni:jni'
FBJNI_TARGET = '//lib/fb:fbjni' FBJNI_TARGET = '//lib/fb:fbjni'
THIS_IS_FBOBJC = False
CXX_LIBRARY_WHITELIST = [ CXX_LIBRARY_WHITELIST = [
'//:CSSLayout',
'//lib/fb:fbjni', '//lib/fb:fbjni',
'//java:jni', '//java:jni',
] ]