DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Added counts for measure callbacks reasons in an array inside qpl annotations

Browse Source 
Summary:
Added an array to maintain the counts of each of the reason of measure callbacks
and this is now added as qpl metadata in Layout Calculation qpl event

Reviewed By: davidaurelio

Differential Revision: D16516379

fbshipit-source-id: 201c5d2463f0a921841a0bbfec8f4d5e007000c8
This commit is contained in:
Sidharth Guglani
2019-07-31 14:33:36 -07:00
committed by Facebook Github Bot
parent 825da1e868
commit 095c991b85
2 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
yoga/Yoga.cpp
View File

@@ -1645,6 +1645,13 @@ static void YGNodeWithMeasureFuncSetMeasuredDimensions(
layoutContext); layoutContext);
layoutMarkerData.measureCallbacks += 1; layoutMarkerData.measureCallbacks += 1;
if (reason == LayoutPassReason::kMeasureChild) {
layoutMarkerData.measureChildMeasureCallbacks += 1;
} else if (reason == LayoutPassReason::kFlexMeasure) {
layoutMarkerData.flexMeasureMeasureCallbacks += 1;
} else if (reason == LayoutPassReason::kAbsMeasureChild) {
layoutMarkerData.absMeasureChildMeasureCallbacks += 1;
}
Event::publish<Event::MeasureCallbackEnd>( Event::publish<Event::MeasureCallbackEnd>(
node, node,

24
yoga/event/event.h
View File

@@ -23,15 +23,6 @@ enum struct LayoutType : int {
kCachedMeasure = 3 kCachedMeasure = 3
}; };
struct LayoutData {
int layouts;
int measures;
int maxMeasureCache;
int cachedLayouts;
int cachedMeasures;
int measureCallbacks;
};
enum struct LayoutPassReason : int { enum struct LayoutPassReason : int {
kInitial = 0, kInitial = 0,
kAbsLayout = 1, kAbsLayout = 1,
@@ -40,7 +31,20 @@ enum struct LayoutPassReason : int {
kFlexLayout = 4, kFlexLayout = 4,
kMeasureChild = 5, kMeasureChild = 5,
kAbsMeasureChild = 6, kAbsMeasureChild = 6,
kFlexMeasure = 7 kFlexMeasure = 7,
COUNT
};
struct LayoutData {
int layouts;
int measures;
int maxMeasureCache;
int cachedLayouts;
int cachedMeasures;
int measureCallbacks;
int measureChildMeasureCallbacks;
int absMeasureChildMeasureCallbacks;
int flexMeasureMeasureCallbacks;
}; };
const char* LayoutPassReasonToString(const LayoutPassReason value); const char* LayoutPassReasonToString(const LayoutPassReason value);