DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove YGExperimentalFeatureFixAbsoluteTrailingColumnMargin (#1317)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1317

X-link: https://github.com/facebook/react-native/pull/37374

This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one).

Reviewed By: yungsters

Differential Revision: D45766764

fbshipit-source-id: b600b79b8436534fe48ef2acbfde8ba64068e593
This commit is contained in:
Nick Gerleman
2023-06-29 11:04:01 -07:00
committed by Facebook GitHub Bot
parent 506027925d
commit 0aec0a1ac4
64 changed files with 5 additions and 825 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
java/tests/com/facebook/yoga/YGMarginTest.java
View File

@@ -29,7 +29,6 @@ public class YGMarginTest {
public void test_margin_start() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -71,7 +70,6 @@ public class YGMarginTest {
public void test_margin_top() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(100f);
@@ -112,7 +110,6 @@ public class YGMarginTest {
public void test_margin_end() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -155,7 +152,6 @@ public class YGMarginTest {
public void test_margin_bottom() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setJustifyContent(YogaJustify.FLEX_END);
@@ -197,7 +193,6 @@ public class YGMarginTest {
public void test_margin_and_flex_row() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -240,7 +235,6 @@ public class YGMarginTest {
public void test_margin_and_flex_column() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(100f);
@@ -282,7 +276,6 @@ public class YGMarginTest {
public void test_margin_and_stretch_row() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -325,7 +318,6 @@ public class YGMarginTest {
public void test_margin_and_stretch_column() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(100f);
@@ -367,7 +359,6 @@ public class YGMarginTest {
public void test_margin_with_sibling_row() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -423,7 +414,6 @@ public class YGMarginTest {
public void test_margin_with_sibling_column() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(100f);
@@ -478,7 +468,6 @@ public class YGMarginTest {
public void test_margin_auto_bottom() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);
@@ -536,7 +525,6 @@ public class YGMarginTest {
public void test_margin_auto_top() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);
@@ -594,7 +582,6 @@ public class YGMarginTest {
public void test_margin_auto_bottom_and_top() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);
@@ -653,7 +640,6 @@ public class YGMarginTest {
public void test_margin_auto_bottom_and_top_justify_center() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setJustifyContent(YogaJustify.CENTER);
@@ -712,7 +698,6 @@ public class YGMarginTest {
public void test_margin_auto_mutiple_children_column() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);
@@ -786,7 +771,6 @@ public class YGMarginTest {
public void test_margin_auto_mutiple_children_row() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -861,7 +845,6 @@ public class YGMarginTest {
public void test_margin_auto_left_and_right_column() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -921,7 +904,6 @@ public class YGMarginTest {
public void test_margin_auto_left_and_right() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(200f);
@@ -979,7 +961,6 @@ public class YGMarginTest {
public void test_margin_auto_start_and_end_column() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -1039,7 +1020,6 @@ public class YGMarginTest {
public void test_margin_auto_start_and_end() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(200f);
@@ -1097,7 +1077,6 @@ public class YGMarginTest {
public void test_margin_auto_left_and_right_column_and_center() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);
@@ -1156,7 +1135,6 @@ public class YGMarginTest {
public void test_margin_auto_left() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);
@@ -1214,7 +1192,6 @@ public class YGMarginTest {
public void test_margin_auto_right() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);
@@ -1272,7 +1249,6 @@ public class YGMarginTest {
public void test_margin_auto_left_and_right_stretch() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setFlexDirection(YogaFlexDirection.ROW);
@@ -1331,7 +1307,6 @@ public class YGMarginTest {
public void test_margin_auto_top_and_bottom_stretch() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(200f);
@@ -1389,7 +1364,6 @@ public class YGMarginTest {
public void test_margin_should_not_be_part_of_max_height() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(250f);
@@ -1432,7 +1406,6 @@ public class YGMarginTest {
public void test_margin_should_not_be_part_of_max_width() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setWidth(250f);
@@ -1475,7 +1448,6 @@ public class YGMarginTest {
public void test_margin_auto_left_right_child_bigger_than_parent() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setJustifyContent(YogaJustify.CENTER);
@@ -1519,7 +1491,6 @@ public class YGMarginTest {
public void test_margin_auto_left_child_bigger_than_parent() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setJustifyContent(YogaJustify.CENTER);
@@ -1562,7 +1533,6 @@ public class YGMarginTest {
public void test_margin_fix_left_auto_right_child_bigger_than_parent() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setJustifyContent(YogaJustify.CENTER);
@@ -1606,7 +1576,6 @@ public class YGMarginTest {
public void test_margin_auto_left_fix_right_child_bigger_than_parent() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setJustifyContent(YogaJustify.CENTER);
@@ -1650,7 +1619,6 @@ public class YGMarginTest {
public void test_margin_auto_top_stretching_child() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);
@@ -1709,7 +1677,6 @@ public class YGMarginTest {
public void test_margin_auto_left_stretching_child() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.FIX_ABSOLUTE_TRAILING_COLUMN_MARGIN, true);
final YogaNode root = createNode(config);
root.setAlignItems(YogaAlign.CENTER);