DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove YGExperimentalFeatureFixAbsoluteTrailingColumnMargin (#1317)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1317

X-link: https://github.com/facebook/react-native/pull/37374

This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one).

Reviewed By: yungsters

Differential Revision: D45766764

fbshipit-source-id: b600b79b8436534fe48ef2acbfde8ba64068e593
This commit is contained in:
Nick Gerleman
2023-06-29 11:04:01 -07:00
committed by Facebook GitHub Bot
parent 506027925d
commit 0aec0a1ac4
64 changed files with 5 additions and 825 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
javascript/tests/generated/YGGapTest.test.ts
View File

@@ -30,7 +30,6 @@ test('column_gap_flexible', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -113,7 +112,6 @@ test('column_gap_inflexible', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -189,7 +187,6 @@ test('column_gap_mixed_flexible', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -267,7 +264,6 @@ test('column_gap_child_margins', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -355,7 +351,6 @@ test('column_row_gap_wrapping', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -525,7 +520,6 @@ test('column_gap_justify_flex_start', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -601,7 +595,6 @@ test('column_gap_justify_center', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -678,7 +671,6 @@ test('column_gap_justify_flex_end', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -755,7 +747,6 @@ test('column_gap_justify_space_between', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -832,7 +823,6 @@ test('column_gap_justify_space_around', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -909,7 +899,6 @@ test('column_gap_justify_space_evenly', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -986,7 +975,6 @@ test('column_gap_wrap_align_flex_start', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1112,7 +1100,6 @@ test('column_gap_wrap_align_center', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1239,7 +1226,6 @@ test('column_gap_wrap_align_flex_end', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1366,7 +1352,6 @@ test('column_gap_wrap_align_space_between', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1493,7 +1478,6 @@ test('column_gap_wrap_align_space_around', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1620,7 +1604,6 @@ test('column_gap_wrap_align_stretch', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1731,7 +1714,6 @@ test('column_gap_determines_parent_width', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1806,7 +1788,6 @@ test('row_gap_align_items_stretch', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1927,7 +1908,6 @@ test('row_gap_align_items_end', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -2048,7 +2028,6 @@ test('row_gap_column_child_margins', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -2135,7 +2114,6 @@ test('row_gap_row_wrap_child_margins', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -2218,7 +2196,6 @@ test('row_gap_determines_parent_height', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);