DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove YGExperimentalFeatureFixAbsoluteTrailingColumnMargin (#1317)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1317

X-link: https://github.com/facebook/react-native/pull/37374

This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one).

Reviewed By: yungsters

Differential Revision: D45766764

fbshipit-source-id: b600b79b8436534fe48ef2acbfde8ba64068e593
This commit is contained in:
Nick Gerleman
2023-06-29 11:04:01 -07:00
committed by Facebook GitHub Bot
parent 506027925d
commit 0aec0a1ac4
64 changed files with 5 additions and 825 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
javascript/tests/generated/YGJustifyContentTest.test.ts
View File

@@ -30,7 +30,6 @@ test('justify_content_row_flex_start', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -105,7 +104,6 @@ test('justify_content_row_flex_end', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -181,7 +179,6 @@ test('justify_content_row_center', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -257,7 +254,6 @@ test('justify_content_row_space_between', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -333,7 +329,6 @@ test('justify_content_row_space_around', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -409,7 +404,6 @@ test('justify_content_column_flex_start', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -483,7 +477,6 @@ test('justify_content_column_flex_end', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -558,7 +551,6 @@ test('justify_content_column_center', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -633,7 +625,6 @@ test('justify_content_column_space_between', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -708,7 +699,6 @@ test('justify_content_column_space_around', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -783,7 +773,6 @@ test('justify_content_row_min_width_and_margin', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -832,7 +821,6 @@ test('justify_content_row_max_width_and_margin', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -882,7 +870,6 @@ test('justify_content_column_min_height_and_margin', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -930,7 +917,6 @@ test('justify_content_colunn_max_height_and_margin', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -979,7 +965,6 @@ test('justify_content_column_space_evenly', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1054,7 +1039,6 @@ test('justify_content_row_space_evenly', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1130,7 +1114,6 @@ test('justify_content_min_width_with_padding_child_width_greater_than_parent', (
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1214,7 +1197,6 @@ test('justify_content_min_width_with_padding_child_width_lower_than_parent', ()
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);