Remove YGNodeSetPrintFunc and related (#1553)

Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1553

X-link: https://github.com/facebook/react-native/pull/42274

Separate from `YGConfigSetPrintTreeFlag` we have a public API `YGNodeSetPrintFunc` which sets a function called, if you manually change a constant in source code during debugging.

This is not debug-only, is exposed as part of the public API (without a way to turn it on from the public API), and takes up a pointer per node doing nothing.

I'm not aware of anyone recently using the capability, and the tracing/event related work done since then would be more powerful for this anyway.

Remove the API.

Changelog: [Internal]

Reviewed By: rozele

Differential Revision: D52767445

fbshipit-source-id: f72927b47cffa4fe6fe886b42f07cc1ba55f141e
This commit is contained in:
Nick Gerleman
2024-01-16 10:07:19 -08:00
committed by Facebook GitHub Bot
parent 508df05f0d
commit 0bbfe4503d
5 changed files with 2 additions and 121 deletions

View File

@@ -35,7 +35,6 @@ Node::Node(Node&& node) {
context_ = node.context_;
measureFunc_ = node.measureFunc_;
baselineFunc_ = node.baselineFunc_;
printFunc_ = node.printFunc_;
dirtiedFunc_ = node.dirtiedFunc_;
style_ = node.style_;
layout_ = node.layout_;
@@ -49,12 +48,6 @@ Node::Node(Node&& node) {
}
}
void Node::print() {
if (printFunc_ != nullptr) {
printFunc_(this);
}
}
// TODO: Edge value resolution should be moved to `yoga::Style`
template <auto Field>
Style::Length Node::computeEdgeValueForRow(Edge rowEdge, Edge edge) const {