DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove YGNodeSetPrintFunc and related (#1553)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1553

X-link: https://github.com/facebook/react-native/pull/42274

Separate from `YGConfigSetPrintTreeFlag` we have a public API `YGNodeSetPrintFunc` which sets a function called, if you manually change a constant in source code during debugging.

This is not debug-only, is exposed as part of the public API (without a way to turn it on from the public API), and takes up a pointer per node doing nothing.

I'm not aware of anyone recently using the capability, and the tracing/event related work done since then would be more powerful for this anyway.

Remove the API.

Changelog: [Internal]

Reviewed By: rozele

Differential Revision: D52767445

fbshipit-source-id: f72927b47cffa4fe6fe886b42f07cc1ba55f141e
This commit is contained in:
Nick Gerleman
2024-01-16 10:07:19 -08:00
committed by Facebook GitHub Bot
parent 508df05f0d
commit 0bbfe4503d
5 changed files with 2 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
yoga/node/Node.h
View File

@@ -52,8 +52,6 @@ class YG_EXPORT Node : public ::YGNode {
return alwaysFormsContainingBlock_;
}
void print();
bool getHasNewLayout() const {
return hasNewLayout_;
}
@@ -250,10 +248,6 @@ class YG_EXPORT Node : public ::YGNode {
alwaysFormsContainingBlock_ = alwaysFormsContainingBlock;
}
void setPrintFunc(YGPrintFunc printFunc) {
printFunc_ = printFunc;
}
void setHasNewLayout(bool hasNewLayout) {
hasNewLayout_ = hasNewLayout;
}
@@ -376,9 +370,8 @@ class YG_EXPORT Node : public ::YGNode {
bool alwaysFormsContainingBlock_ : 1 = false;
NodeType nodeType_ : bitCount<NodeType>() = NodeType::Default;
void* context_ = nullptr;
YGMeasureFunc measureFunc_ = {nullptr};
YGBaselineFunc baselineFunc_ = {nullptr};
YGPrintFunc printFunc_ = {nullptr};
YGMeasureFunc measureFunc_ = nullptr;
YGBaselineFunc baselineFunc_ = nullptr;
YGDirtiedFunc dirtiedFunc_ = nullptr;
Style style_ = {};
LayoutResults layout_ = {};