DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Don't enable ordinalCount() or bitCount() for bitset enums

Browse Source 
Summary:
Bitfield enums are not sequential, so use of these functions on these enums would be invalid.

I looked at whether we could trivially move `bitCount` to template based on `ordinalCount`. `bitCount` must be constexpr, since we use it directly as a bit-field size constant. `log2` and `ceil` to be constexpr, which isn't here until C++ 26.

Reviewed By: javache

Differential Revision: D51518899

fbshipit-source-id: 256f15bbed517be6f90bf43baa43ce96e9259a71
This commit is contained in:
Nick Gerleman
2023-11-22 11:06:31 -08:00
committed by Facebook GitHub Bot
parent c7c81e3c89
commit 0eb861b459
3 changed files with 11 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
yoga/enums/Errata.h
View File

@@ -26,16 +26,6 @@ enum class Errata : uint32_t {
YG_DEFINE_ENUM_FLAG_OPERATORS(Errata)
template <>
constexpr inline int32_t ordinalCount<Errata>() {
return 6;
}
template <>
constexpr inline int32_t bitCount<Errata>() {
return 3;
}
constexpr inline Errata scopedEnum(YGErrata unscoped) {
return static_cast<Errata>(unscoped);
}

10
yoga/enums/PrintOptions.h
View File

@@ -23,16 +23,6 @@ enum class PrintOptions : uint32_t {
YG_DEFINE_ENUM_FLAG_OPERATORS(PrintOptions)
template <>
constexpr inline int32_t ordinalCount<PrintOptions>() {
return 3;
}
template <>
constexpr inline int32_t bitCount<PrintOptions>() {
return 2;
}
constexpr inline PrintOptions scopedEnum(YGPrintOptions unscoped) {
return static_cast<PrintOptions>(unscoped);
}