From 15afb4207cf7c300c00210413df0187bd38aa06a Mon Sep 17 00:00:00 2001 From: rh389 Date: Wed, 24 Aug 2016 10:40:32 -0700 Subject: [PATCH] Use quote style for local includes Summary: This PR changes `#include ` to `#include "*.h"` within the `CSSLayout` directory. Rationale: Quote includes are preferred for user (aka local/project) includes, whereas angle includes are preferred for standard libraries and external frameworks. In particular, XCode 7.1+ will not search user paths (even the current directory) when angle brackets are used unless "Always search user paths" is enabled - it is off by default and [Apple recommend](https://developer.apple.com/library/mac/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW110) that it is only enabled for backwards compatibility. I think this is the best fix for https://github.com/facebook/react-native/issues/9014, and seems like good practice in any case. Closes https://github.com/facebook/css-layout/pull/217 Reviewed By: majak Differential Revision: D3764132 Pulled By: emilsjolander fbshipit-source-id: c8a6e8d19db71455922e3ba8f6c72bd66018fa84 --- CSSLayout/CSSLayout-internal.h | 4 ++-- CSSLayout/CSSLayout.h | 2 +- CSSLayout/CSSNodeList.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CSSLayout/CSSLayout-internal.h b/CSSLayout/CSSLayout-internal.h index da46bfdc..da417da3 100644 --- a/CSSLayout/CSSLayout-internal.h +++ b/CSSLayout/CSSLayout-internal.h @@ -9,8 +9,8 @@ #pragma once -#include -#include +#include "CSSLayout.h" +#include "CSSNodeList.h" CSS_EXTERN_C_BEGIN diff --git a/CSSLayout/CSSLayout.h b/CSSLayout/CSSLayout.h index 37d0bff7..3ebce685 100644 --- a/CSSLayout/CSSLayout.h +++ b/CSSLayout/CSSLayout.h @@ -27,7 +27,7 @@ static const unsigned long __nan[2] = {0xffffffff, 0x7fffffff}; #define CSSUndefined NAN -#include +#include "CSSMacros.h" CSS_EXTERN_C_BEGIN diff --git a/CSSLayout/CSSNodeList.h b/CSSLayout/CSSNodeList.h index 922852f9..6d2ca6ce 100644 --- a/CSSLayout/CSSNodeList.h +++ b/CSSLayout/CSSNodeList.h @@ -14,8 +14,8 @@ #include #include -#include -#include +#include "CSSLayout.h" +#include "CSSMacros.h" CSS_EXTERN_C_BEGIN