DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Refactor cloning of YogaNode

Browse Source 
Summary: see Test Plan

Reviewed By: priteshrnandgaonkar

Differential Revision: D7339832

fbshipit-source-id: 2de6f47ae7601ac083d3b9fbe10ffaf6307ae760
This commit is contained in:
David Vacca
2018-04-01 18:27:04 -07:00
committed by Facebook Github Bot
parent 187fc54596
commit 17901ea5c2
9 changed files with 103 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
java/tests/com/facebook/yoga/YogaNodeTest.java
View File

@@ -255,12 +255,17 @@ public class YogaNodeTest {
public void testCloneNodeListener() throws Exception {
final AtomicBoolean onNodeClonedExecuted = new AtomicBoolean(false);
YogaConfig config = new YogaConfig();
config.setOnNodeCloned(
new YogaNodeClonedFunction() {
config.setOnCloneNode(
new YogaNodeCloneFunction() {
@Override
public void onNodeCloned(
YogaNode oldNode, YogaNode newNode, YogaNode parent, int childIndex) {
onNodeClonedExecuted.set(true);
public YogaNode cloneNode(YogaNode oldNode, YogaNode parent, int childIndex) {
try {
onNodeClonedExecuted.set(true);
return oldNode.clone();
} catch (CloneNotSupportedException ex) {
// DO nothing
return null;
}
}
});
YogaNode root = new YogaNode(config);
@@ -268,6 +273,7 @@ public class YogaNodeTest {
root.setHeight(100f);
YogaNode child0 = new YogaNode(config);
root.addChildAt(child0, 0);
child0.setWidth(50f);
root.calculateLayout(YogaConstants.UNDEFINED, YogaConstants.UNDEFINED);
// Force a clone to happen.
@@ -276,20 +282,29 @@ public class YogaNodeTest {
root2.calculateLayout(YogaConstants.UNDEFINED, YogaConstants.UNDEFINED);
assertTrue(onNodeClonedExecuted.get());
assertEquals(1, root2.getChildCount());
YogaNode clonedNode = root2.getChildAt(0);
assertNotSame(child0, clonedNode);
assertEquals(child0.getWidth(), clonedNode.getWidth());
assertEquals(50f, clonedNode.getWidth().value, 0.01f);
}
@Test
public void testOnNodeClonedLeak() throws Exception {
YogaConfig config = new YogaConfig();
config.setOnNodeCloned(
new YogaNodeClonedFunction() {
config.setOnCloneNode(
new YogaNodeCloneFunction() {
@Override
public void onNodeCloned(
YogaNode oldNode, YogaNode newNode, YogaNode parent, int childIndex) {
// Do nothing
public YogaNode cloneNode(YogaNode oldNode, YogaNode parent, int childIndex) {
try {
return oldNode.clone();
} catch (CloneNotSupportedException ex) {
// DO nothing
return null;
}
}
});
config.setOnNodeCloned(null);
config.setOnCloneNode(null);
WeakReference<Object> ref = new WeakReference<Object>(config);
// noinspection UnusedAssignment
config = null;