Revive JavaScript Bindings (#1177)
Summary: Yoga's JavaScript bindings do not work past Node 10, or on recent versions of Ubuntu even using it. This is due to a reliance on `nbind`, a library which is no longer maintained. `nbind` itself abstracts over `embind` running Emscripten to generate an asm.js build, along with building Node native modules. In the meantime, [yoga-layout-prebuilt](https://www.npmjs.com/package/yoga-layout-prebuilt) has been used by the community instead of the official package. https://github.com/facebook/yoga/pull/1177 was contributed as a conversion of bindings created using `nbind` to instead use `embind` directly. I continued building on this to add more: 1. WebAssembly support (required to be async in browsers) 2. CMake + Ninja Build for the 4 flavors 3. TypeScript typings (partially generated) 4. yarn scripts to build (working on macOS, Ubuntu, Windows) 5. A README with some usage and contribution instructions 6. Updated tests to work with Jest, and updated general infra 7. ESLint and clang-format scripts 8. More GitHub actions (and now testing Windows) 9. Probably more I kinda got carried away here lol The plan is to eventually publish this to NPM, but there is a little bit of work after this before that happens. Pull Request resolved: https://github.com/facebook/yoga/pull/1177 Test Plan: The bindings pass Jest tests (both manual and generated). GitHub actions added for the different yarn scripts. Did some manual checks on using the library as TS. Reviewed By: christophpurrer Differential Revision: D42207782 Pulled By: NickGerleman fbshipit-source-id: 1dc5ce440f1c2b9705a005bbdcc86f952785d94e
This commit is contained in:
committed by
Facebook GitHub Bot
parent
8035456330
commit
1813748eaa
@@ -5,7 +5,7 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
var JavascriptEmitter = function() {
|
||||
const JavascriptEmitter = function() {
|
||||
Emitter.call(this, 'js', ' ');
|
||||
};
|
||||
|
||||
@@ -17,9 +17,8 @@ function toValueJavascript(value) {
|
||||
}
|
||||
|
||||
function toJavascriptUpper(symbol) {
|
||||
var out = '';
|
||||
for (var i = 0; i < symbol.length; i++) {
|
||||
var c = symbol[i];
|
||||
let out = '';
|
||||
for (const c of symbol) {
|
||||
if (c == c.toUpperCase() && i != 0 && symbol[i - 1] != symbol[i - 1].toUpperCase()) {
|
||||
out += '_';
|
||||
}
|
||||
@@ -31,21 +30,17 @@ function toJavascriptUpper(symbol) {
|
||||
JavascriptEmitter.prototype = Object.create(Emitter.prototype, {
|
||||
constructor:{value:JavascriptEmitter},
|
||||
|
||||
emitPrologue:{value:function() {
|
||||
this.push([
|
||||
'var Yoga = Yoga || require("../../sources/entry-" + process.env.TEST_ENTRY);',
|
||||
''
|
||||
]);
|
||||
}},
|
||||
emitPrologue:{value:function() {}},
|
||||
|
||||
emitTestPrologue:{value:function(name, experiments) {
|
||||
this.push('it(' + JSON.stringify(name) + ', function () {');
|
||||
this.push('test(' + JSON.stringify(name) + ', () => {');
|
||||
this.pushIndent();
|
||||
this.push('var config = Yoga.Config.create();');
|
||||
this.push('const config = Yoga.Config.create();');
|
||||
this.push('let root;');
|
||||
this.push('');
|
||||
|
||||
if (experiments.length > 0) {
|
||||
for (var i in experiments) {
|
||||
for (const i in experiments) {
|
||||
this.push('config.setExperimentalFeatureEnabled(Yoga.EXPERIMENTAL_FEATURE_' + toJavascriptUpper(experiments[i]) + ', true);');
|
||||
}
|
||||
this.push('');
|
||||
@@ -56,7 +51,11 @@ JavascriptEmitter.prototype = Object.create(Emitter.prototype, {
|
||||
}},
|
||||
|
||||
emitTestTreePrologue:{value:function(nodeName) {
|
||||
this.push('var ' + nodeName + ' = Yoga.Node.create(config);');
|
||||
if (nodeName === 'root') {
|
||||
this.push(`root = Yoga.Node.create(config);`);
|
||||
} else {
|
||||
this.push(`const ${nodeName} = Yoga.Node.create(config);`);
|
||||
}
|
||||
}},
|
||||
|
||||
emitTestEpilogue:{value:function(experiments) {
|
||||
@@ -84,7 +83,7 @@ JavascriptEmitter.prototype = Object.create(Emitter.prototype, {
|
||||
}},
|
||||
|
||||
AssertEQ:{value:function(v0, v1) {
|
||||
this.push('console.assert(' + v0 + ' === ' + v1 + ', "' + v0 + ' === ' + v1 + ' (" + ' + v1 + ' + ")");');
|
||||
this.push(`expect(${v1}).toBe(${v0});`);
|
||||
}},
|
||||
|
||||
YGAlignAuto:{value:'Yoga.ALIGN_AUTO'},
|
||||
|
@@ -56,7 +56,7 @@ Dir['fixtures/*.html'].each do |file|
|
||||
|
||||
print logs[4]
|
||||
|
||||
f = File.open("../javascript/tests/Facebook.Yoga/#{name}.js", 'w')
|
||||
f = File.open("../javascript/tests/generated/#{name}.test.js", 'w')
|
||||
f.write eval(logs[3].message.sub(/^[^"]*/, '')).sub('YogaTest', name)
|
||||
f.close
|
||||
end
|
||||
|
Reference in New Issue
Block a user