Undeprecate Config setting APIs (#1251)
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1251 X-link: https://github.com/facebook/react-native/pull/36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133646 fbshipit-source-id: 2bb15c4825717793529cdad8542447d11e723e35
This commit is contained in:
committed by
Facebook GitHub Bot
parent
5fd3240f85
commit
19e15a4455
@@ -16,7 +16,6 @@
|
||||
#include "YGConfig.h"
|
||||
#include "YGLayout.h"
|
||||
#include "YGStyle.h"
|
||||
#include "YGMacros.h"
|
||||
#include "Yoga-internal.h"
|
||||
|
||||
YGConfigRef YGConfigGetDefault();
|
||||
@@ -307,7 +306,7 @@ public:
|
||||
|
||||
// TODO: rvalue override for setChildren
|
||||
|
||||
YG_DEPRECATED void setConfig(YGConfigRef config) { config_ = config; }
|
||||
void setConfig(YGConfigRef config) { config_ = config; }
|
||||
|
||||
void setDirty(bool isDirty);
|
||||
void setLayoutLastOwnerDirection(YGDirection direction);
|
||||
|
Reference in New Issue
Block a user