Fixes for publish workflows (#1319)
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1319 This fixes a few issues encountered during publishing Yoga `2.0.0-beta.1`. 1. The tag trigger was missing quotes needed to be valid syntax 2. `pod trunk publish` must be run with `--synchronous` if we are publishing a package that relies on another just published package. There does not seem to be a way to just publish evertything at once. 3. `yarn publish` was not reading the NPM auth token from the environment, so we write it to a `.npmrc` before publishing. 4. The root `.gitignore` was not updated when moving to yarn workspaces to ignore `node_modules`, so the OSS Yoga repo (not internal) will, try to add its contents after `yarn install`. Reviewed By: cortinico Differential Revision: D47135994 fbshipit-source-id: d8c9b05176a98443be1ebc7cf74996f22520d20d
This commit is contained in:
committed by
Facebook GitHub Bot
parent
cdc3328ca5
commit
1b40f05b8c
@@ -3,7 +3,7 @@ name: Publish CocoaPods Release
|
||||
on:
|
||||
push:
|
||||
tags:
|
||||
- *
|
||||
- '*'
|
||||
workflow_dispatch:
|
||||
|
||||
jobs:
|
||||
@@ -23,6 +23,7 @@ jobs:
|
||||
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}
|
||||
|
||||
- name: Publish YogaKit
|
||||
run: pod trunk push YogaKit.podspec
|
||||
# Must run with --synchronous since YogaKit may depend on the just published version of Yoga
|
||||
run: pod trunk push YogaKit.podspec --synchronous
|
||||
env:
|
||||
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}
|
||||
|
Reference in New Issue
Block a user