DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Enable previously broken absolute positioning tests (#1488)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1488

These were disabled when they were written because they were broken. The recent changes made them pass now so lets enable them. I also added another test that is already passing

Reviewed By: NickGerleman

Differential Revision: D51404875

fbshipit-source-id: ed10004968b871c1d033640d75138f00afc15968
This commit is contained in:
Joe Vilches
2023-12-07 21:25:45 -08:00
committed by Facebook GitHub Bot
parent bc5dc2d6bf
commit 1ea575684d
8 changed files with 196 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gentest/fixtures/YGAbsolutePositionTest.html
View File

@@ -101,15 +101,15 @@
<div style="position:absolute; width:100px; height:50%;"></div>
</div>
<div id="absolute_layout_padding_left" data-disabled="true" style="width:200px; height:200px; padding-left:100px;">
<div id="absolute_layout_padding_left" style="width:200px; height:200px; padding-left:100px;">
<div style="position:absolute; width:50px; height:50px;"></div>
</div>
<div id="absolute_layout_padding_right" data-disabled="true" style="width:200px; height:200px; padding-right:100px;">
<div id="absolute_layout_padding_right" style="width:200px; height:200px; padding-right:100px;">
<div style="position:absolute; width:50px; height:50px;"></div>
</div>
<div id="absolute_layout_padding_top" data-disabled="true" style="width:200px; height:200px; padding-top:100px;">
<div id="absolute_layout_padding_top" style="width:200px; height:200px; padding-top:100px;">
<div style="position:absolute; width:50px; height:50px;"></div>
</div>

9
gentest/fixtures/YGStaticPositionTest.html
View File

@@ -304,7 +304,7 @@
</div>
</div>
<div id="static_position_absolute_child_containing_block_content_box" data-disabled="true">
<div id="static_position_absolute_child_containing_block_content_box">
<div style="width: 400px; height: 400px; padding: 100px; position: relative">
<div style="height:50px; width: 50%; position: absolute">
</div>
@@ -633,3 +633,10 @@
</div>
</div>
</div>
<div id="static_position_static_root"
style="height:200px; width: 100px; position: static; padding: 1px 11px 4px 6px;">
<div
style="height: 50%; width: 50%; position: absolute; border-width: 3px 2px 1px 4px; padding: 7px 5px 4px 3px; margin: 11px 15px 1px 12px">
</div>
</div>