DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Enable previously broken absolute positioning tests (#1488)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1488

These were disabled when they were written because they were broken. The recent changes made them pass now so lets enable them. I also added another test that is already passing

Reviewed By: NickGerleman

Differential Revision: D51404875

fbshipit-source-id: ed10004968b871c1d033640d75138f00afc15968
This commit is contained in:
Joe Vilches
2023-12-07 21:25:45 -08:00
committed by Facebook GitHub Bot
parent bc5dc2d6bf
commit 1ea575684d
8 changed files with 196 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/tests/com/facebook/yoga/YGAbsolutePositionTest.java
View File

@@ -1214,7 +1214,6 @@ public class YGAbsolutePositionTest {
}
@Test
@Ignore
public void test_absolute_layout_padding_left() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -1258,7 +1257,6 @@ public class YGAbsolutePositionTest {
}
@Test
@Ignore
public void test_absolute_layout_padding_right() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -1302,7 +1300,6 @@ public class YGAbsolutePositionTest {
}
@Test
@Ignore
public void test_absolute_layout_padding_top() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);

59
java/tests/com/facebook/yoga/YGStaticPositionTest.java
View File

@@ -2477,7 +2477,6 @@ public class YGStaticPositionTest {
}
@Test
@Ignore
public void test_static_position_absolute_child_containing_block_content_box() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -5442,6 +5441,64 @@ public class YGStaticPositionTest {
assertEquals(50f, root_child0_child0_child2_child0.getLayoutHeight(), 0.0f);
}
@Test
public void test_static_position_static_root() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
final YogaNode root = createNode(config);
root.setPositionType(YogaPositionType.STATIC);
root.setPadding(YogaEdge.LEFT, 6);
root.setPadding(YogaEdge.TOP, 1);
root.setPadding(YogaEdge.RIGHT, 11);
root.setPadding(YogaEdge.BOTTOM, 4);
root.setWidth(100f);
root.setHeight(200f);
final YogaNode root_child0 = createNode(config);
root_child0.setPositionType(YogaPositionType.ABSOLUTE);
root_child0.setMargin(YogaEdge.LEFT, 12f);
root_child0.setMargin(YogaEdge.TOP, 11f);
root_child0.setMargin(YogaEdge.RIGHT, 15f);
root_child0.setMargin(YogaEdge.BOTTOM, 1f);
root_child0.setPadding(YogaEdge.LEFT, 3);
root_child0.setPadding(YogaEdge.TOP, 7);
root_child0.setPadding(YogaEdge.RIGHT, 5);
root_child0.setPadding(YogaEdge.BOTTOM, 4);
root_child0.setBorder(YogaEdge.LEFT, 4f);
root_child0.setBorder(YogaEdge.TOP, 3f);
root_child0.setBorder(YogaEdge.RIGHT, 2f);
root_child0.setBorder(YogaEdge.BOTTOM, 1f);
root_child0.setWidthPercent(50f);
root_child0.setHeightPercent(50f);
root.addChildAt(root_child0, 0);
root.setDirection(YogaDirection.LTR);
root.calculateLayout(YogaConstants.UNDEFINED, YogaConstants.UNDEFINED);
assertEquals(0f, root.getLayoutX(), 0.0f);
assertEquals(0f, root.getLayoutY(), 0.0f);
assertEquals(100f, root.getLayoutWidth(), 0.0f);
assertEquals(200f, root.getLayoutHeight(), 0.0f);
assertEquals(18f, root_child0.getLayoutX(), 0.0f);
assertEquals(12f, root_child0.getLayoutY(), 0.0f);
assertEquals(50f, root_child0.getLayoutWidth(), 0.0f);
assertEquals(100f, root_child0.getLayoutHeight(), 0.0f);
root.setDirection(YogaDirection.RTL);
root.calculateLayout(YogaConstants.UNDEFINED, YogaConstants.UNDEFINED);
assertEquals(0f, root.getLayoutX(), 0.0f);
assertEquals(0f, root.getLayoutY(), 0.0f);
assertEquals(100f, root.getLayoutWidth(), 0.0f);
assertEquals(200f, root.getLayoutHeight(), 0.0f);
assertEquals(24f, root_child0.getLayoutX(), 0.0f);
assertEquals(12f, root_child0.getLayoutY(), 0.0f);
assertEquals(50f, root_child0.getLayoutWidth(), 0.0f);
assertEquals(100f, root_child0.getLayoutHeight(), 0.0f);
}
private YogaNode createNode(YogaConfig config) {
return mNodeFactory.create(config);
}