DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Enable previously broken absolute positioning tests (#1488)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1488

These were disabled when they were written because they were broken. The recent changes made them pass now so lets enable them. I also added another test that is already passing

Reviewed By: NickGerleman

Differential Revision: D51404875

fbshipit-source-id: ed10004968b871c1d033640d75138f00afc15968
This commit is contained in:
Joe Vilches
2023-12-07 21:25:45 -08:00
committed by Facebook GitHub Bot
parent bc5dc2d6bf
commit 1ea575684d
8 changed files with 196 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/generated/YGAbsolutePositionTest.cpp
View File

@@ -1225,8 +1225,6 @@ TEST(YogaTest, absolute_layout_percentage_height_based_on_padded_parent_and_alig
}
TEST(YogaTest, absolute_layout_padding_left) {
GTEST_SKIP();
const YGConfigRef config = YGConfigNew();
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
@@ -1271,8 +1269,6 @@ TEST(YogaTest, absolute_layout_padding_left) {
}
TEST(YogaTest, absolute_layout_padding_right) {
GTEST_SKIP();
const YGConfigRef config = YGConfigNew();
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
@@ -1317,8 +1313,6 @@ TEST(YogaTest, absolute_layout_padding_right) {
}
TEST(YogaTest, absolute_layout_padding_top) {
GTEST_SKIP();
const YGConfigRef config = YGConfigNew();
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);

61
tests/generated/YGStaticPositionTest.cpp
View File

@@ -2497,8 +2497,6 @@ TEST(YogaTest, static_position_static_child_containing_block_padding_box) {
}
TEST(YogaTest, static_position_absolute_child_containing_block_content_box) {
GTEST_SKIP();
const YGConfigRef config = YGConfigNew();
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
@@ -5482,3 +5480,62 @@ TEST(YogaTest, static_position_align_flex_end_amalgamation) {
YGConfigFree(config);
}
TEST(YogaTest, static_position_static_root) {
const YGConfigRef config = YGConfigNew();
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
const YGNodeRef root = YGNodeNewWithConfig(config);
YGNodeStyleSetPositionType(root, YGPositionTypeStatic);
YGNodeStyleSetPadding(root, YGEdgeLeft, 6);
YGNodeStyleSetPadding(root, YGEdgeTop, 1);
YGNodeStyleSetPadding(root, YGEdgeRight, 11);
YGNodeStyleSetPadding(root, YGEdgeBottom, 4);
YGNodeStyleSetWidth(root, 100);
YGNodeStyleSetHeight(root, 200);
const YGNodeRef root_child0 = YGNodeNewWithConfig(config);
YGNodeStyleSetPositionType(root_child0, YGPositionTypeAbsolute);
YGNodeStyleSetMargin(root_child0, YGEdgeLeft, 12);
YGNodeStyleSetMargin(root_child0, YGEdgeTop, 11);
YGNodeStyleSetMargin(root_child0, YGEdgeRight, 15);
YGNodeStyleSetMargin(root_child0, YGEdgeBottom, 1);
YGNodeStyleSetPadding(root_child0, YGEdgeLeft, 3);
YGNodeStyleSetPadding(root_child0, YGEdgeTop, 7);
YGNodeStyleSetPadding(root_child0, YGEdgeRight, 5);
YGNodeStyleSetPadding(root_child0, YGEdgeBottom, 4);
YGNodeStyleSetBorder(root_child0, YGEdgeLeft, 4);
YGNodeStyleSetBorder(root_child0, YGEdgeTop, 3);
YGNodeStyleSetBorder(root_child0, YGEdgeRight, 2);
YGNodeStyleSetBorder(root_child0, YGEdgeBottom, 1);
YGNodeStyleSetWidthPercent(root_child0, 50);
YGNodeStyleSetHeightPercent(root_child0, 50);
YGNodeInsertChild(root, root_child0, 0);
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root));
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root));
ASSERT_FLOAT_EQ(100, YGNodeLayoutGetWidth(root));
ASSERT_FLOAT_EQ(200, YGNodeLayoutGetHeight(root));
ASSERT_FLOAT_EQ(18, YGNodeLayoutGetLeft(root_child0));
ASSERT_FLOAT_EQ(12, YGNodeLayoutGetTop(root_child0));
ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child0));
ASSERT_FLOAT_EQ(100, YGNodeLayoutGetHeight(root_child0));
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionRTL);
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root));
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root));
ASSERT_FLOAT_EQ(100, YGNodeLayoutGetWidth(root));
ASSERT_FLOAT_EQ(200, YGNodeLayoutGetHeight(root));
ASSERT_FLOAT_EQ(24, YGNodeLayoutGetLeft(root_child0));
ASSERT_FLOAT_EQ(12, YGNodeLayoutGetTop(root_child0));
ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child0));
ASSERT_FLOAT_EQ(100, YGNodeLayoutGetHeight(root_child0));
YGNodeFreeRecursive(root);
YGConfigFree(config);
}