DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove YGExperimentalFeatureFixAbsoluteTrailingColumnMargin (#1317)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1317

X-link: https://github.com/facebook/react-native/pull/37374

This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one).

Reviewed By: yungsters

Differential Revision: D45766764

fbshipit-source-id: 9a7a23842335bffafa573c164a166b9ab8080160
This commit is contained in:
Nick Gerleman
2023-06-28 14:37:52 -07:00
committed by Facebook GitHub Bot
parent 506027925d
commit 1ec2b780dc
64 changed files with 5 additions and 825 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
javascript/tests/generated/YGMarginTest.test.ts
View File

@@ -30,7 +30,6 @@ test('margin_start', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -78,7 +77,6 @@ test('margin_top', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -125,7 +123,6 @@ test('margin_end', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -174,7 +171,6 @@ test('margin_bottom', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -222,7 +218,6 @@ test('margin_and_flex_row', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -271,7 +266,6 @@ test('margin_and_flex_column', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -319,7 +313,6 @@ test('margin_and_stretch_row', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -368,7 +361,6 @@ test('margin_and_stretch_column', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -416,7 +408,6 @@ test('margin_with_sibling_row', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -478,7 +469,6 @@ test('margin_with_sibling_column', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -539,7 +529,6 @@ test('margin_auto_bottom', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -603,7 +592,6 @@ test('margin_auto_top', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -667,7 +655,6 @@ test('margin_auto_bottom_and_top', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -732,7 +719,6 @@ test('margin_auto_bottom_and_top_justify_center', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -797,7 +783,6 @@ test('margin_auto_mutiple_children_column', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -877,7 +862,6 @@ test('margin_auto_mutiple_children_row', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -958,7 +942,6 @@ test('margin_auto_left_and_right_column', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1024,7 +1007,6 @@ test('margin_auto_left_and_right', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1088,7 +1070,6 @@ test('margin_auto_start_and_end_column', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1154,7 +1135,6 @@ test('margin_auto_start_and_end', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1218,7 +1198,6 @@ test('margin_auto_left_and_right_column_and_center', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1283,7 +1262,6 @@ test('margin_auto_left', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1347,7 +1325,6 @@ test('margin_auto_right', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1411,7 +1388,6 @@ test('margin_auto_left_and_right_stretch', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1476,7 +1452,6 @@ test('margin_auto_top_and_bottom_stretch', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1540,7 +1515,6 @@ test('margin_should_not_be_part_of_max_height', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1589,7 +1563,6 @@ test('margin_should_not_be_part_of_max_width', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1638,7 +1611,6 @@ test('margin_auto_left_right_child_bigger_than_parent', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1688,7 +1660,6 @@ test('margin_auto_left_child_bigger_than_parent', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1737,7 +1708,6 @@ test('margin_fix_left_auto_right_child_bigger_than_parent', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1787,7 +1757,6 @@ test('margin_auto_left_fix_right_child_bigger_than_parent', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1837,7 +1806,6 @@ test('margin_auto_top_stretching_child', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1902,7 +1870,6 @@ test('margin_auto_left_stretching_child', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);