DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove YGExperimentalFeatureFixAbsoluteTrailingColumnMargin (#1317)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1317

X-link: https://github.com/facebook/react-native/pull/37374

This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one).

Reviewed By: yungsters

Differential Revision: D45766764

fbshipit-source-id: 9a7a23842335bffafa573c164a166b9ab8080160
This commit is contained in:
Nick Gerleman
2023-06-28 14:37:52 -07:00
committed by Facebook GitHub Bot
parent 506027925d
commit 1ec2b780dc
64 changed files with 5 additions and 825 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
javascript/tests/generated/YGRoundingTest.test.ts
View File

@@ -30,7 +30,6 @@ test('rounding_flex_basis_flex_grow_row_width_of_100', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -105,7 +104,6 @@ test('rounding_flex_basis_flex_grow_row_prime_number_width', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -208,7 +206,6 @@ test('rounding_flex_basis_flex_shrink_row', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -284,7 +281,6 @@ test('rounding_flex_basis_overrides_main_size', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -362,7 +358,6 @@ test('rounding_total_fractial', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -440,7 +435,6 @@ test('rounding_total_fractial_nested', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -552,7 +546,6 @@ test('rounding_fractial_input_1', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -630,7 +623,6 @@ test('rounding_fractial_input_2', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -708,7 +700,6 @@ test('rounding_fractial_input_3', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -787,7 +778,6 @@ test('rounding_fractial_input_4', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -866,7 +856,6 @@ test('rounding_inner_node_controversy_horizontal', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -958,7 +947,6 @@ test('rounding_inner_node_controversy_vertical', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);
@@ -1049,7 +1037,6 @@ test('rounding_inner_node_controversy_combined', () => {
let root;
config.setExperimentalFeatureEnabled(ExperimentalFeature.AbsolutePercentageAgainstPaddingEdge, true);
config.setExperimentalFeatureEnabled(ExperimentalFeature.FixAbsoluteTrailingColumnMargin, true);
try {
root = Yoga.Node.create(config);