DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix min/max not overriding width/height

Browse Source 
Summary:
Two bugs:
1. Min/Max width/height should have higher priority than width/height
2. custom measure nodes percentages should be based in parent size like everything else.

Differential Revision: D4537576

fbshipit-source-id: c003f723f424afbca63170d41e54fd5ff837926d
This commit is contained in:
Emil Sjolander
2017-02-11 05:26:55 -08:00
committed by Facebook Github Bot
parent a5b94ebd0c
commit 240c2dd657
8 changed files with 631 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
gentest/fixtures/YGMinMaxDimensionTest.html
View File

@@ -63,3 +63,20 @@
<div style="flex-shrink:1; flex-basis:100px"></div>
<div style="height: 50px;"></div>
</div>
<div id="min_width_overrides_width" style="min-width: 100px; width: 50px;">
</div>
<div id="max_width_overrides_width" style="max-width: 100px; width: 200px;">
</div>
<div id="min_height_overrides_height" style="min-height: 100px; height: 50px;">
</div>
<div id="max_height_overrides_height" style="max-height: 100px; height: 200px;">
</div>
<div id="min_max_percent_no_width_height" style="width: 100px; height: 100px; align-items: flex-start;">
<div style="min-width: 10%; max-width: 10%; min-height: 10%; max-height: 10%;">
</div>
</div>