diff --git a/csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs b/csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs
index 313095ab..a2213119 100644
--- a/csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs
+++ b/csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs
@@ -296,6 +296,242 @@ namespace Facebook.Yoga
Assert.AreEqual(10f, root_child1_child0.LayoutHeight);
}
+ [Test]
+ public void Test_align_baseline_child_multiline()
+ {
+ YogaNode root = new YogaNode();
+ root.FlexDirection = YogaFlexDirection.Row;
+ root.AlignItems = YogaAlign.Baseline;
+ root.Width = 100;
+ root.Height = 100;
+
+ YogaNode root_child0 = new YogaNode();
+ root_child0.Width = 50;
+ root_child0.Height = 60;
+ root.Insert(0, root_child0);
+
+ YogaNode root_child1 = new YogaNode();
+ root_child1.FlexDirection = YogaFlexDirection.Row;
+ root_child1.Wrap = YogaWrap.Wrap;
+ root_child1.Width = 50;
+ root_child1.Height = 25;
+ root.Insert(1, root_child1);
+
+ YogaNode root_child1_child0 = new YogaNode();
+ root_child1_child0.Width = 25;
+ root_child1_child0.Height = 20;
+ root_child1.Insert(0, root_child1_child0);
+
+ YogaNode root_child1_child1 = new YogaNode();
+ root_child1_child1.Width = 25;
+ root_child1_child1.Height = 10;
+ root_child1.Insert(1, root_child1_child1);
+
+ YogaNode root_child1_child2 = new YogaNode();
+ root_child1_child2.Width = 25;
+ root_child1_child2.Height = 20;
+ root_child1.Insert(2, root_child1_child2);
+
+ YogaNode root_child1_child3 = new YogaNode();
+ root_child1_child3.Width = 25;
+ root_child1_child3.Height = 10;
+ root_child1.Insert(3, root_child1_child3);
+ root.StyleDirection = YogaDirection.LTR;
+ root.CalculateLayout();
+
+ Assert.AreEqual(0f, root.LayoutX);
+ Assert.AreEqual(0f, root.LayoutY);
+ Assert.AreEqual(100f, root.LayoutWidth);
+ Assert.AreEqual(100f, root.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child0.LayoutX);
+ Assert.AreEqual(0f, root_child0.LayoutY);
+ Assert.AreEqual(50f, root_child0.LayoutWidth);
+ Assert.AreEqual(60f, root_child0.LayoutHeight);
+
+ Assert.AreEqual(50f, root_child1.LayoutX);
+ Assert.AreEqual(40f, root_child1.LayoutY);
+ Assert.AreEqual(50f, root_child1.LayoutWidth);
+ Assert.AreEqual(25f, root_child1.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1_child0.LayoutX);
+ Assert.AreEqual(0f, root_child1_child0.LayoutY);
+ Assert.AreEqual(25f, root_child1_child0.LayoutWidth);
+ Assert.AreEqual(20f, root_child1_child0.LayoutHeight);
+
+ Assert.AreEqual(25f, root_child1_child1.LayoutX);
+ Assert.AreEqual(0f, root_child1_child1.LayoutY);
+ Assert.AreEqual(25f, root_child1_child1.LayoutWidth);
+ Assert.AreEqual(10f, root_child1_child1.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1_child2.LayoutX);
+ Assert.AreEqual(20f, root_child1_child2.LayoutY);
+ Assert.AreEqual(25f, root_child1_child2.LayoutWidth);
+ Assert.AreEqual(20f, root_child1_child2.LayoutHeight);
+
+ Assert.AreEqual(25f, root_child1_child3.LayoutX);
+ Assert.AreEqual(20f, root_child1_child3.LayoutY);
+ Assert.AreEqual(25f, root_child1_child3.LayoutWidth);
+ Assert.AreEqual(10f, root_child1_child3.LayoutHeight);
+
+ root.StyleDirection = YogaDirection.RTL;
+ root.CalculateLayout();
+
+ Assert.AreEqual(0f, root.LayoutX);
+ Assert.AreEqual(0f, root.LayoutY);
+ Assert.AreEqual(100f, root.LayoutWidth);
+ Assert.AreEqual(100f, root.LayoutHeight);
+
+ Assert.AreEqual(50f, root_child0.LayoutX);
+ Assert.AreEqual(0f, root_child0.LayoutY);
+ Assert.AreEqual(50f, root_child0.LayoutWidth);
+ Assert.AreEqual(60f, root_child0.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1.LayoutX);
+ Assert.AreEqual(40f, root_child1.LayoutY);
+ Assert.AreEqual(50f, root_child1.LayoutWidth);
+ Assert.AreEqual(25f, root_child1.LayoutHeight);
+
+ Assert.AreEqual(25f, root_child1_child0.LayoutX);
+ Assert.AreEqual(0f, root_child1_child0.LayoutY);
+ Assert.AreEqual(25f, root_child1_child0.LayoutWidth);
+ Assert.AreEqual(20f, root_child1_child0.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1_child1.LayoutX);
+ Assert.AreEqual(0f, root_child1_child1.LayoutY);
+ Assert.AreEqual(25f, root_child1_child1.LayoutWidth);
+ Assert.AreEqual(10f, root_child1_child1.LayoutHeight);
+
+ Assert.AreEqual(25f, root_child1_child2.LayoutX);
+ Assert.AreEqual(20f, root_child1_child2.LayoutY);
+ Assert.AreEqual(25f, root_child1_child2.LayoutWidth);
+ Assert.AreEqual(20f, root_child1_child2.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1_child3.LayoutX);
+ Assert.AreEqual(20f, root_child1_child3.LayoutY);
+ Assert.AreEqual(25f, root_child1_child3.LayoutWidth);
+ Assert.AreEqual(10f, root_child1_child3.LayoutHeight);
+ }
+
+ [Test]
+ public void Test_align_baseline_child_multiline_override()
+ {
+ YogaNode root = new YogaNode();
+ root.FlexDirection = YogaFlexDirection.Row;
+ root.AlignItems = YogaAlign.Baseline;
+ root.Width = 100;
+ root.Height = 100;
+
+ YogaNode root_child0 = new YogaNode();
+ root_child0.Width = 50;
+ root_child0.Height = 60;
+ root.Insert(0, root_child0);
+
+ YogaNode root_child1 = new YogaNode();
+ root_child1.FlexDirection = YogaFlexDirection.Row;
+ root_child1.Wrap = YogaWrap.Wrap;
+ root_child1.Width = 50;
+ root_child1.Height = 25;
+ root.Insert(1, root_child1);
+
+ YogaNode root_child1_child0 = new YogaNode();
+ root_child1_child0.Width = 25;
+ root_child1_child0.Height = 20;
+ root_child1.Insert(0, root_child1_child0);
+
+ YogaNode root_child1_child1 = new YogaNode();
+ root_child1_child1.AlignSelf = YogaAlign.Baseline;
+ root_child1_child1.Width = 25;
+ root_child1_child1.Height = 10;
+ root_child1.Insert(1, root_child1_child1);
+
+ YogaNode root_child1_child2 = new YogaNode();
+ root_child1_child2.Width = 25;
+ root_child1_child2.Height = 20;
+ root_child1.Insert(2, root_child1_child2);
+
+ YogaNode root_child1_child3 = new YogaNode();
+ root_child1_child3.AlignSelf = YogaAlign.Baseline;
+ root_child1_child3.Width = 25;
+ root_child1_child3.Height = 10;
+ root_child1.Insert(3, root_child1_child3);
+ root.StyleDirection = YogaDirection.LTR;
+ root.CalculateLayout();
+
+ Assert.AreEqual(0f, root.LayoutX);
+ Assert.AreEqual(0f, root.LayoutY);
+ Assert.AreEqual(100f, root.LayoutWidth);
+ Assert.AreEqual(100f, root.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child0.LayoutX);
+ Assert.AreEqual(0f, root_child0.LayoutY);
+ Assert.AreEqual(50f, root_child0.LayoutWidth);
+ Assert.AreEqual(60f, root_child0.LayoutHeight);
+
+ Assert.AreEqual(50f, root_child1.LayoutX);
+ Assert.AreEqual(50f, root_child1.LayoutY);
+ Assert.AreEqual(50f, root_child1.LayoutWidth);
+ Assert.AreEqual(25f, root_child1.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1_child0.LayoutX);
+ Assert.AreEqual(0f, root_child1_child0.LayoutY);
+ Assert.AreEqual(25f, root_child1_child0.LayoutWidth);
+ Assert.AreEqual(20f, root_child1_child0.LayoutHeight);
+
+ Assert.AreEqual(25f, root_child1_child1.LayoutX);
+ Assert.AreEqual(0f, root_child1_child1.LayoutY);
+ Assert.AreEqual(25f, root_child1_child1.LayoutWidth);
+ Assert.AreEqual(10f, root_child1_child1.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1_child2.LayoutX);
+ Assert.AreEqual(20f, root_child1_child2.LayoutY);
+ Assert.AreEqual(25f, root_child1_child2.LayoutWidth);
+ Assert.AreEqual(20f, root_child1_child2.LayoutHeight);
+
+ Assert.AreEqual(25f, root_child1_child3.LayoutX);
+ Assert.AreEqual(20f, root_child1_child3.LayoutY);
+ Assert.AreEqual(25f, root_child1_child3.LayoutWidth);
+ Assert.AreEqual(10f, root_child1_child3.LayoutHeight);
+
+ root.StyleDirection = YogaDirection.RTL;
+ root.CalculateLayout();
+
+ Assert.AreEqual(0f, root.LayoutX);
+ Assert.AreEqual(0f, root.LayoutY);
+ Assert.AreEqual(100f, root.LayoutWidth);
+ Assert.AreEqual(100f, root.LayoutHeight);
+
+ Assert.AreEqual(50f, root_child0.LayoutX);
+ Assert.AreEqual(0f, root_child0.LayoutY);
+ Assert.AreEqual(50f, root_child0.LayoutWidth);
+ Assert.AreEqual(60f, root_child0.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1.LayoutX);
+ Assert.AreEqual(50f, root_child1.LayoutY);
+ Assert.AreEqual(50f, root_child1.LayoutWidth);
+ Assert.AreEqual(25f, root_child1.LayoutHeight);
+
+ Assert.AreEqual(25f, root_child1_child0.LayoutX);
+ Assert.AreEqual(0f, root_child1_child0.LayoutY);
+ Assert.AreEqual(25f, root_child1_child0.LayoutWidth);
+ Assert.AreEqual(20f, root_child1_child0.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1_child1.LayoutX);
+ Assert.AreEqual(0f, root_child1_child1.LayoutY);
+ Assert.AreEqual(25f, root_child1_child1.LayoutWidth);
+ Assert.AreEqual(10f, root_child1_child1.LayoutHeight);
+
+ Assert.AreEqual(25f, root_child1_child2.LayoutX);
+ Assert.AreEqual(20f, root_child1_child2.LayoutY);
+ Assert.AreEqual(25f, root_child1_child2.LayoutWidth);
+ Assert.AreEqual(20f, root_child1_child2.LayoutHeight);
+
+ Assert.AreEqual(0f, root_child1_child3.LayoutX);
+ Assert.AreEqual(20f, root_child1_child3.LayoutY);
+ Assert.AreEqual(25f, root_child1_child3.LayoutWidth);
+ Assert.AreEqual(10f, root_child1_child3.LayoutHeight);
+ }
+
[Test]
public void Test_align_baseline_child_top()
{
diff --git a/gentest/fixtures/YGAlignItemsTest.html b/gentest/fixtures/YGAlignItemsTest.html
index d8ed2c5f..1fc829ba 100644
--- a/gentest/fixtures/YGAlignItemsTest.html
+++ b/gentest/fixtures/YGAlignItemsTest.html
@@ -26,6 +26,27 @@
+
diff --git a/java/tests/com/facebook/yoga/YGAlignItemsTest.java b/java/tests/com/facebook/yoga/YGAlignItemsTest.java
index 11b18989..0a5f5cb4 100644
--- a/java/tests/com/facebook/yoga/YGAlignItemsTest.java
+++ b/java/tests/com/facebook/yoga/YGAlignItemsTest.java
@@ -289,6 +289,240 @@ public class YGAlignItemsTest {
assertEquals(10f, root_child1_child0.getLayoutHeight(), 0.0f);
}
+ @Test
+ public void test_align_baseline_child_multiline() {
+ final YogaNode root = new YogaNode();
+ root.setFlexDirection(YogaFlexDirection.ROW);
+ root.setAlignItems(YogaAlign.BASELINE);
+ root.setWidth(100f);
+ root.setHeight(100f);
+
+ final YogaNode root_child0 = new YogaNode();
+ root_child0.setWidth(50f);
+ root_child0.setHeight(60f);
+ root.addChildAt(root_child0, 0);
+
+ final YogaNode root_child1 = new YogaNode();
+ root_child1.setFlexDirection(YogaFlexDirection.ROW);
+ root_child1.setWrap(YogaWrap.WRAP);
+ root_child1.setWidth(50f);
+ root_child1.setHeight(25f);
+ root.addChildAt(root_child1, 1);
+
+ final YogaNode root_child1_child0 = new YogaNode();
+ root_child1_child0.setWidth(25f);
+ root_child1_child0.setHeight(20f);
+ root_child1.addChildAt(root_child1_child0, 0);
+
+ final YogaNode root_child1_child1 = new YogaNode();
+ root_child1_child1.setWidth(25f);
+ root_child1_child1.setHeight(10f);
+ root_child1.addChildAt(root_child1_child1, 1);
+
+ final YogaNode root_child1_child2 = new YogaNode();
+ root_child1_child2.setWidth(25f);
+ root_child1_child2.setHeight(20f);
+ root_child1.addChildAt(root_child1_child2, 2);
+
+ final YogaNode root_child1_child3 = new YogaNode();
+ root_child1_child3.setWidth(25f);
+ root_child1_child3.setHeight(10f);
+ root_child1.addChildAt(root_child1_child3, 3);
+ root.setDirection(YogaDirection.LTR);
+ root.calculateLayout();
+
+ assertEquals(0f, root.getLayoutX(), 0.0f);
+ assertEquals(0f, root.getLayoutY(), 0.0f);
+ assertEquals(100f, root.getLayoutWidth(), 0.0f);
+ assertEquals(100f, root.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child0.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child0.getLayoutY(), 0.0f);
+ assertEquals(50f, root_child0.getLayoutWidth(), 0.0f);
+ assertEquals(60f, root_child0.getLayoutHeight(), 0.0f);
+
+ assertEquals(50f, root_child1.getLayoutX(), 0.0f);
+ assertEquals(40f, root_child1.getLayoutY(), 0.0f);
+ assertEquals(50f, root_child1.getLayoutWidth(), 0.0f);
+ assertEquals(25f, root_child1.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1_child0.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child1_child0.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child0.getLayoutWidth(), 0.0f);
+ assertEquals(20f, root_child1_child0.getLayoutHeight(), 0.0f);
+
+ assertEquals(25f, root_child1_child1.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child1_child1.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child1.getLayoutWidth(), 0.0f);
+ assertEquals(10f, root_child1_child1.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1_child2.getLayoutX(), 0.0f);
+ assertEquals(20f, root_child1_child2.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child2.getLayoutWidth(), 0.0f);
+ assertEquals(20f, root_child1_child2.getLayoutHeight(), 0.0f);
+
+ assertEquals(25f, root_child1_child3.getLayoutX(), 0.0f);
+ assertEquals(20f, root_child1_child3.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child3.getLayoutWidth(), 0.0f);
+ assertEquals(10f, root_child1_child3.getLayoutHeight(), 0.0f);
+
+ root.setDirection(YogaDirection.RTL);
+ root.calculateLayout();
+
+ assertEquals(0f, root.getLayoutX(), 0.0f);
+ assertEquals(0f, root.getLayoutY(), 0.0f);
+ assertEquals(100f, root.getLayoutWidth(), 0.0f);
+ assertEquals(100f, root.getLayoutHeight(), 0.0f);
+
+ assertEquals(50f, root_child0.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child0.getLayoutY(), 0.0f);
+ assertEquals(50f, root_child0.getLayoutWidth(), 0.0f);
+ assertEquals(60f, root_child0.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1.getLayoutX(), 0.0f);
+ assertEquals(40f, root_child1.getLayoutY(), 0.0f);
+ assertEquals(50f, root_child1.getLayoutWidth(), 0.0f);
+ assertEquals(25f, root_child1.getLayoutHeight(), 0.0f);
+
+ assertEquals(25f, root_child1_child0.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child1_child0.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child0.getLayoutWidth(), 0.0f);
+ assertEquals(20f, root_child1_child0.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1_child1.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child1_child1.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child1.getLayoutWidth(), 0.0f);
+ assertEquals(10f, root_child1_child1.getLayoutHeight(), 0.0f);
+
+ assertEquals(25f, root_child1_child2.getLayoutX(), 0.0f);
+ assertEquals(20f, root_child1_child2.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child2.getLayoutWidth(), 0.0f);
+ assertEquals(20f, root_child1_child2.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1_child3.getLayoutX(), 0.0f);
+ assertEquals(20f, root_child1_child3.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child3.getLayoutWidth(), 0.0f);
+ assertEquals(10f, root_child1_child3.getLayoutHeight(), 0.0f);
+ }
+
+ @Test
+ public void test_align_baseline_child_multiline_override() {
+ final YogaNode root = new YogaNode();
+ root.setFlexDirection(YogaFlexDirection.ROW);
+ root.setAlignItems(YogaAlign.BASELINE);
+ root.setWidth(100f);
+ root.setHeight(100f);
+
+ final YogaNode root_child0 = new YogaNode();
+ root_child0.setWidth(50f);
+ root_child0.setHeight(60f);
+ root.addChildAt(root_child0, 0);
+
+ final YogaNode root_child1 = new YogaNode();
+ root_child1.setFlexDirection(YogaFlexDirection.ROW);
+ root_child1.setWrap(YogaWrap.WRAP);
+ root_child1.setWidth(50f);
+ root_child1.setHeight(25f);
+ root.addChildAt(root_child1, 1);
+
+ final YogaNode root_child1_child0 = new YogaNode();
+ root_child1_child0.setWidth(25f);
+ root_child1_child0.setHeight(20f);
+ root_child1.addChildAt(root_child1_child0, 0);
+
+ final YogaNode root_child1_child1 = new YogaNode();
+ root_child1_child1.setAlignSelf(YogaAlign.BASELINE);
+ root_child1_child1.setWidth(25f);
+ root_child1_child1.setHeight(10f);
+ root_child1.addChildAt(root_child1_child1, 1);
+
+ final YogaNode root_child1_child2 = new YogaNode();
+ root_child1_child2.setWidth(25f);
+ root_child1_child2.setHeight(20f);
+ root_child1.addChildAt(root_child1_child2, 2);
+
+ final YogaNode root_child1_child3 = new YogaNode();
+ root_child1_child3.setAlignSelf(YogaAlign.BASELINE);
+ root_child1_child3.setWidth(25f);
+ root_child1_child3.setHeight(10f);
+ root_child1.addChildAt(root_child1_child3, 3);
+ root.setDirection(YogaDirection.LTR);
+ root.calculateLayout();
+
+ assertEquals(0f, root.getLayoutX(), 0.0f);
+ assertEquals(0f, root.getLayoutY(), 0.0f);
+ assertEquals(100f, root.getLayoutWidth(), 0.0f);
+ assertEquals(100f, root.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child0.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child0.getLayoutY(), 0.0f);
+ assertEquals(50f, root_child0.getLayoutWidth(), 0.0f);
+ assertEquals(60f, root_child0.getLayoutHeight(), 0.0f);
+
+ assertEquals(50f, root_child1.getLayoutX(), 0.0f);
+ assertEquals(50f, root_child1.getLayoutY(), 0.0f);
+ assertEquals(50f, root_child1.getLayoutWidth(), 0.0f);
+ assertEquals(25f, root_child1.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1_child0.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child1_child0.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child0.getLayoutWidth(), 0.0f);
+ assertEquals(20f, root_child1_child0.getLayoutHeight(), 0.0f);
+
+ assertEquals(25f, root_child1_child1.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child1_child1.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child1.getLayoutWidth(), 0.0f);
+ assertEquals(10f, root_child1_child1.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1_child2.getLayoutX(), 0.0f);
+ assertEquals(20f, root_child1_child2.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child2.getLayoutWidth(), 0.0f);
+ assertEquals(20f, root_child1_child2.getLayoutHeight(), 0.0f);
+
+ assertEquals(25f, root_child1_child3.getLayoutX(), 0.0f);
+ assertEquals(20f, root_child1_child3.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child3.getLayoutWidth(), 0.0f);
+ assertEquals(10f, root_child1_child3.getLayoutHeight(), 0.0f);
+
+ root.setDirection(YogaDirection.RTL);
+ root.calculateLayout();
+
+ assertEquals(0f, root.getLayoutX(), 0.0f);
+ assertEquals(0f, root.getLayoutY(), 0.0f);
+ assertEquals(100f, root.getLayoutWidth(), 0.0f);
+ assertEquals(100f, root.getLayoutHeight(), 0.0f);
+
+ assertEquals(50f, root_child0.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child0.getLayoutY(), 0.0f);
+ assertEquals(50f, root_child0.getLayoutWidth(), 0.0f);
+ assertEquals(60f, root_child0.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1.getLayoutX(), 0.0f);
+ assertEquals(50f, root_child1.getLayoutY(), 0.0f);
+ assertEquals(50f, root_child1.getLayoutWidth(), 0.0f);
+ assertEquals(25f, root_child1.getLayoutHeight(), 0.0f);
+
+ assertEquals(25f, root_child1_child0.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child1_child0.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child0.getLayoutWidth(), 0.0f);
+ assertEquals(20f, root_child1_child0.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1_child1.getLayoutX(), 0.0f);
+ assertEquals(0f, root_child1_child1.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child1.getLayoutWidth(), 0.0f);
+ assertEquals(10f, root_child1_child1.getLayoutHeight(), 0.0f);
+
+ assertEquals(25f, root_child1_child2.getLayoutX(), 0.0f);
+ assertEquals(20f, root_child1_child2.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child2.getLayoutWidth(), 0.0f);
+ assertEquals(20f, root_child1_child2.getLayoutHeight(), 0.0f);
+
+ assertEquals(0f, root_child1_child3.getLayoutX(), 0.0f);
+ assertEquals(20f, root_child1_child3.getLayoutY(), 0.0f);
+ assertEquals(25f, root_child1_child3.getLayoutWidth(), 0.0f);
+ assertEquals(10f, root_child1_child3.getLayoutHeight(), 0.0f);
+ }
+
@Test
public void test_align_baseline_child_top() {
final YogaNode root = new YogaNode();
diff --git a/tests/YGAlignItemsTest.cpp b/tests/YGAlignItemsTest.cpp
index 52698927..092bb26f 100644
--- a/tests/YGAlignItemsTest.cpp
+++ b/tests/YGAlignItemsTest.cpp
@@ -279,6 +279,238 @@ TEST(YogaTest, align_baseline_child) {
YGNodeFreeRecursive(root);
}
+TEST(YogaTest, align_baseline_child_multiline) {
+ const YGNodeRef root = YGNodeNew();
+ YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
+ YGNodeStyleSetAlignItems(root, YGAlignBaseline);
+ YGNodeStyleSetWidth(root, 100);
+ YGNodeStyleSetHeight(root, 100);
+
+ const YGNodeRef root_child0 = YGNodeNew();
+ YGNodeStyleSetWidth(root_child0, 50);
+ YGNodeStyleSetHeight(root_child0, 60);
+ YGNodeInsertChild(root, root_child0, 0);
+
+ const YGNodeRef root_child1 = YGNodeNew();
+ YGNodeStyleSetFlexDirection(root_child1, YGFlexDirectionRow);
+ YGNodeStyleSetFlexWrap(root_child1, YGWrapWrap);
+ YGNodeStyleSetWidth(root_child1, 50);
+ YGNodeStyleSetHeight(root_child1, 25);
+ YGNodeInsertChild(root, root_child1, 1);
+
+ const YGNodeRef root_child1_child0 = YGNodeNew();
+ YGNodeStyleSetWidth(root_child1_child0, 25);
+ YGNodeStyleSetHeight(root_child1_child0, 20);
+ YGNodeInsertChild(root_child1, root_child1_child0, 0);
+
+ const YGNodeRef root_child1_child1 = YGNodeNew();
+ YGNodeStyleSetWidth(root_child1_child1, 25);
+ YGNodeStyleSetHeight(root_child1_child1, 10);
+ YGNodeInsertChild(root_child1, root_child1_child1, 1);
+
+ const YGNodeRef root_child1_child2 = YGNodeNew();
+ YGNodeStyleSetWidth(root_child1_child2, 25);
+ YGNodeStyleSetHeight(root_child1_child2, 20);
+ YGNodeInsertChild(root_child1, root_child1_child2, 2);
+
+ const YGNodeRef root_child1_child3 = YGNodeNew();
+ YGNodeStyleSetWidth(root_child1_child3, 25);
+ YGNodeStyleSetHeight(root_child1_child3, 10);
+ YGNodeInsertChild(root_child1, root_child1_child3, 3);
+ YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root));
+ ASSERT_FLOAT_EQ(100, YGNodeLayoutGetWidth(root));
+ ASSERT_FLOAT_EQ(100, YGNodeLayoutGetHeight(root));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child0));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child0));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child0));
+ ASSERT_FLOAT_EQ(60, YGNodeLayoutGetHeight(root_child0));
+
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetLeft(root_child1));
+ ASSERT_FLOAT_EQ(40, YGNodeLayoutGetTop(root_child1));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child1));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetHeight(root_child1));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1_child0));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child1_child0));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child0));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetHeight(root_child1_child0));
+
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetLeft(root_child1_child1));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child1_child1));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child1));
+ ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(root_child1_child1));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1_child2));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetTop(root_child1_child2));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child2));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetHeight(root_child1_child2));
+
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetLeft(root_child1_child3));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetTop(root_child1_child3));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child3));
+ ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(root_child1_child3));
+
+ YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionRTL);
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root));
+ ASSERT_FLOAT_EQ(100, YGNodeLayoutGetWidth(root));
+ ASSERT_FLOAT_EQ(100, YGNodeLayoutGetHeight(root));
+
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetLeft(root_child0));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child0));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child0));
+ ASSERT_FLOAT_EQ(60, YGNodeLayoutGetHeight(root_child0));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1));
+ ASSERT_FLOAT_EQ(40, YGNodeLayoutGetTop(root_child1));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child1));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetHeight(root_child1));
+
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetLeft(root_child1_child0));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child1_child0));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child0));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetHeight(root_child1_child0));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1_child1));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child1_child1));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child1));
+ ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(root_child1_child1));
+
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetLeft(root_child1_child2));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetTop(root_child1_child2));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child2));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetHeight(root_child1_child2));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1_child3));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetTop(root_child1_child3));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child3));
+ ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(root_child1_child3));
+
+ YGNodeFreeRecursive(root);
+}
+
+TEST(YogaTest, align_baseline_child_multiline_override) {
+ const YGNodeRef root = YGNodeNew();
+ YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
+ YGNodeStyleSetAlignItems(root, YGAlignBaseline);
+ YGNodeStyleSetWidth(root, 100);
+ YGNodeStyleSetHeight(root, 100);
+
+ const YGNodeRef root_child0 = YGNodeNew();
+ YGNodeStyleSetWidth(root_child0, 50);
+ YGNodeStyleSetHeight(root_child0, 60);
+ YGNodeInsertChild(root, root_child0, 0);
+
+ const YGNodeRef root_child1 = YGNodeNew();
+ YGNodeStyleSetFlexDirection(root_child1, YGFlexDirectionRow);
+ YGNodeStyleSetFlexWrap(root_child1, YGWrapWrap);
+ YGNodeStyleSetWidth(root_child1, 50);
+ YGNodeStyleSetHeight(root_child1, 25);
+ YGNodeInsertChild(root, root_child1, 1);
+
+ const YGNodeRef root_child1_child0 = YGNodeNew();
+ YGNodeStyleSetWidth(root_child1_child0, 25);
+ YGNodeStyleSetHeight(root_child1_child0, 20);
+ YGNodeInsertChild(root_child1, root_child1_child0, 0);
+
+ const YGNodeRef root_child1_child1 = YGNodeNew();
+ YGNodeStyleSetAlignSelf(root_child1_child1, YGAlignBaseline);
+ YGNodeStyleSetWidth(root_child1_child1, 25);
+ YGNodeStyleSetHeight(root_child1_child1, 10);
+ YGNodeInsertChild(root_child1, root_child1_child1, 1);
+
+ const YGNodeRef root_child1_child2 = YGNodeNew();
+ YGNodeStyleSetWidth(root_child1_child2, 25);
+ YGNodeStyleSetHeight(root_child1_child2, 20);
+ YGNodeInsertChild(root_child1, root_child1_child2, 2);
+
+ const YGNodeRef root_child1_child3 = YGNodeNew();
+ YGNodeStyleSetAlignSelf(root_child1_child3, YGAlignBaseline);
+ YGNodeStyleSetWidth(root_child1_child3, 25);
+ YGNodeStyleSetHeight(root_child1_child3, 10);
+ YGNodeInsertChild(root_child1, root_child1_child3, 3);
+ YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root));
+ ASSERT_FLOAT_EQ(100, YGNodeLayoutGetWidth(root));
+ ASSERT_FLOAT_EQ(100, YGNodeLayoutGetHeight(root));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child0));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child0));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child0));
+ ASSERT_FLOAT_EQ(60, YGNodeLayoutGetHeight(root_child0));
+
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetLeft(root_child1));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetTop(root_child1));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child1));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetHeight(root_child1));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1_child0));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child1_child0));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child0));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetHeight(root_child1_child0));
+
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetLeft(root_child1_child1));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child1_child1));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child1));
+ ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(root_child1_child1));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1_child2));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetTop(root_child1_child2));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child2));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetHeight(root_child1_child2));
+
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetLeft(root_child1_child3));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetTop(root_child1_child3));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child3));
+ ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(root_child1_child3));
+
+ YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionRTL);
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root));
+ ASSERT_FLOAT_EQ(100, YGNodeLayoutGetWidth(root));
+ ASSERT_FLOAT_EQ(100, YGNodeLayoutGetHeight(root));
+
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetLeft(root_child0));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child0));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child0));
+ ASSERT_FLOAT_EQ(60, YGNodeLayoutGetHeight(root_child0));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetTop(root_child1));
+ ASSERT_FLOAT_EQ(50, YGNodeLayoutGetWidth(root_child1));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetHeight(root_child1));
+
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetLeft(root_child1_child0));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child1_child0));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child0));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetHeight(root_child1_child0));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1_child1));
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetTop(root_child1_child1));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child1));
+ ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(root_child1_child1));
+
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetLeft(root_child1_child2));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetTop(root_child1_child2));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child2));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetHeight(root_child1_child2));
+
+ ASSERT_FLOAT_EQ(0, YGNodeLayoutGetLeft(root_child1_child3));
+ ASSERT_FLOAT_EQ(20, YGNodeLayoutGetTop(root_child1_child3));
+ ASSERT_FLOAT_EQ(25, YGNodeLayoutGetWidth(root_child1_child3));
+ ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(root_child1_child3));
+
+ YGNodeFreeRecursive(root);
+}
+
TEST(YogaTest, align_baseline_child_top) {
const YGNodeRef root = YGNodeNew();
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
diff --git a/yoga/Yoga.c b/yoga/Yoga.c
index a88f3c71..4b0d021b 100644
--- a/yoga/Yoga.c
+++ b/yoga/Yoga.c
@@ -938,7 +938,7 @@ static inline float YGNodePaddingAndBorderForAxis(const YGNodeRef node,
}
static inline YGAlign YGNodeAlignItem(const YGNodeRef node, const YGNodeRef child) {
- YGAlign align =
+ const YGAlign align =
child->style.alignSelf == YGAlignAuto ? node->style.alignItems : child->style.alignSelf;
if (align == YGAlignBaseline && YGFlexDirectionIsColumn(node->style.flexDirection)) {
return YGAlignFlexStart;
@@ -955,12 +955,11 @@ static inline YGDirection YGNodeResolveDirection(const YGNodeRef node,
}
}
-static float YGBaseline(const YGNodeRef node,
- const YGFlexDirection crossAxis) {
+static float YGBaseline(const YGNodeRef node) {
if (node->baseline != NULL) {
const float baseline = node->baseline(node);
if (YGFloatIsUndefined(baseline)) {
- return node->layout.measuredDimensions[dim[crossAxis]];
+ return node->layout.measuredDimensions[YGDimensionHeight];
}
return baseline;
}
@@ -983,11 +982,11 @@ static float YGBaseline(const YGNodeRef node,
}
if (baselineChild == NULL) {
- return node->layout.measuredDimensions[dim[crossAxis]];
+ return node->layout.measuredDimensions[YGDimensionHeight];
}
- const float baseline = YGBaseline(baselineChild, crossAxis);
- return baseline + baselineChild->layout.position[pos[crossAxis]];
+ const float baseline = YGBaseline(baselineChild);
+ return baseline + baselineChild->layout.position[YGEdgeTop];
}
static inline YGFlexDirection YGFlexDirectionResolve(const YGFlexDirection flexDirection,
@@ -1019,7 +1018,6 @@ static bool YGIsBaselineLayout(const YGNodeRef node) {
if (node->style.alignItems == YGAlignBaseline) {
return true;
}
-
for (uint32_t i = 0; i < YGNodeGetChildCount(node); i++) {
const YGNodeRef child = YGNodeGetChild(node, i);
if (child->style.positionType == YGPositionTypeRelative &&
@@ -2531,7 +2529,7 @@ static void YGNodelayoutImpl(const YGNodeRef node,
YGNodeMarginForAxis(child, crossAxis, availableInnerWidth));
}
if (YGNodeAlignItem(node, child) == YGAlignBaseline) {
- const float ascent = YGBaseline(child, crossAxis) +
+ const float ascent = YGBaseline(child) +
YGNodeLeadingMargin(child, crossAxis, availableInnerWidth);
const float descent = child->layout.measuredDimensions[dim[crossAxis]] +
YGNodeMarginForAxis(child, crossAxis, availableInnerWidth) -
@@ -2578,7 +2576,7 @@ static void YGNodelayoutImpl(const YGNodeRef node,
}
case YGAlignBaseline: {
child->layout.position[pos[crossAxis]] =
- currentLead + maxAscentForCurrentLine - YGBaseline(child, crossAxis) +
+ currentLead + maxAscentForCurrentLine - YGBaseline(child) +
YGNodeLeadingPosition(child, crossAxis, availableInnerCrossDim);
break;
}
diff --git a/yoga/Yoga.h b/yoga/Yoga.h
index 205dd34b..1b23b54b 100644
--- a/yoga/Yoga.h
+++ b/yoga/Yoga.h
@@ -49,7 +49,6 @@ typedef YGSize (*YGMeasureFunc)(YGNodeRef node,
YGMeasureMode widthMode,
float height,
YGMeasureMode heightMode);
-
typedef float (*YGBaselineFunc)(YGNodeRef node);
typedef void (*YGPrintFunc)(YGNodeRef node);