DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

YGEdge -> yoga::Edge (#1461)

Browse Source 
Summary:
X-link: https://github.com/facebook/react-native/pull/41391

Pull Request resolved: https://github.com/facebook/yoga/pull/1461

Converts usages of `YGEdge` within internal APIs to `yoga::Edge` scoped enum.

With the exception of YGUnit which is in its own state of transition, this is the last public yoga enum to need to be moved to scoped enum form for usages internal to the Yoga public API.

Changelog: [internal]

Reviewed By: rshest

Differential Revision: D51152779

fbshipit-source-id: 06554f67bfd7709cbc24fdd9a5474e897e9e95d8
This commit is contained in:
Nick Gerleman
2023-11-25 20:41:22 -08:00
committed by Facebook GitHub Bot
parent a121483e81
commit 325ccea068
12 changed files with 243 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
yoga/node/Node.h
View File

@@ -16,6 +16,7 @@
#include <yoga/config/Config.h>
#include <yoga/enums/Dimension.h>
#include <yoga/enums/Direction.h>
#include <yoga/enums/Edge.h>
#include <yoga/enums/Errata.h>
#include <yoga/enums/MeasureMode.h>
#include <yoga/enums/NodeType.h>
@@ -52,10 +53,10 @@ class YG_EXPORT Node : public ::YGNode {
Direction direction,
const float axisSize) const;
YGEdge getInlineStartEdgeUsingErrata(
Edge getInlineStartEdgeUsingErrata(
FlexDirection flexDirection,
Direction direction) const;
YGEdge getInlineEndEdgeUsingErrata(
Edge getInlineEndEdgeUsingErrata(
FlexDirection flexDirection,
Direction direction) const;
@@ -65,10 +66,10 @@ class YG_EXPORT Node : public ::YGNode {
}
template <auto Field>
Style::Length computeEdgeValueForColumn(YGEdge edge) const;
Style::Length computeEdgeValueForColumn(Edge edge) const;
template <auto Field>
Style::Length computeEdgeValueForRow(YGEdge rowEdge, YGEdge edge) const;
Style::Length computeEdgeValueForRow(Edge rowEdge, Edge edge) const;
// DANGER DANGER DANGER!
// If the node assigned to has children, we'd either have to deallocate
@@ -328,10 +329,10 @@ class YG_EXPORT Node : public ::YGNode {
void setLayoutHadOverflow(bool hadOverflow);
void setLayoutDimension(float LengthValue, Dimension dimension);
void setLayoutDirection(Direction direction);
void setLayoutMargin(float margin, YGEdge edge);
void setLayoutBorder(float border, YGEdge edge);
void setLayoutPadding(float padding, YGEdge edge);
void setLayoutPosition(float position, YGEdge edge);
void setLayoutMargin(float margin, Edge edge);
void setLayoutBorder(float border, Edge edge);
void setLayoutPadding(float padding, Edge edge);
void setLayoutPosition(float position, Edge edge);
void setPosition(
const Direction direction,
const float mainSize,