DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

fix type mismatches in YogaLogger#log function

Browse Source 
Summary: This diff fixes two issues with the JNI integration of YogaLogger#log. (1) The YogaLogger class descriptor was missing a semicolon. This causes a ClassNotFoundException whenever you try to call the log method from C++. (2) The C++ signature for the class was using YogaNodeJNIBase as an arg but the Java signature was using YogaNode. This causes a MethodNotFoundException whenever you try to call the method after fixing problem 1.

Reviewed By: astreet

Differential Revision: D17439957

fbshipit-source-id: be3c16512558050265565b3688fb09a7da31b9b2
This commit is contained in:
Uts Sikder
2019-09-18 21:29:20 -07:00
committed by Facebook Github Bot
parent ad5b3410f0
commit 36eae205e1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/jni/YGJTypes.h
View File

@@ -26,7 +26,7 @@ struct JYogaLogLevel : public facebook::jni::JavaClass<JYogaLogLevel> {
}; };
struct JYogaLogger : public facebook::jni::JavaClass<JYogaLogger> { struct JYogaLogger : public facebook::jni::JavaClass<JYogaLogger> {
static constexpr auto kJavaDescriptor = "Lcom/facebook/yoga/YogaLogger"; static constexpr auto kJavaDescriptor = "Lcom/facebook/yoga/YogaLogger;";
void log( void log(
facebook::jni::alias_ref<JYogaNode>, facebook::jni::alias_ref<JYogaNode>,