DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Breaking: Fix callback const-correctness (#1369)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1369

X-link: https://github.com/facebook/react-native/pull/39370

This fixes const-correctness of callbacks (e.g. not letting a logger function modify nodes during layout). This helps us to continue to fix const-correctness issues inside of Yoga.

This change is breaking to the public API, since it requires a change in signature passed to Yoga.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D49130714

fbshipit-source-id: 07e396e6c4f5688a1494210bbd7da9159870eeb9
This commit is contained in:
Nick Gerleman
2023-09-11 19:00:27 -07:00
committed by Facebook GitHub Bot
parent 86a202b1b6
commit 38153b715a
22 changed files with 111 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/YGLoggerTest.cpp
View File

@@ -14,8 +14,8 @@
namespace {
char writeBuffer[4096];
int _unmanagedLogger(
const YGConfigRef /*config*/,
const YGNodeRef /*node*/,
const YGConfigConstRef /*config*/,
const YGNodeConstRef /*node*/,
YGLogLevel /*level*/,
const char* format,
va_list args) {