DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Hidden/shown nodes are updated now.

Browse Source 
See https://github.com/facebook/css-layout/issues/241
This commit is contained in:
roxlu
2016-12-01 13:11:41 +01:00
parent c113b755ec
commit 38ae7ea4ec
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
CSSLayout/CSSLayout.c
View File

@@ -291,11 +291,13 @@ bool CSSNodeIsDirty(const CSSNodeRef node) {
void CSSNodeHide(const CSSNodeRef node) { void CSSNodeHide(const CSSNodeRef node) {
node->isVisible = false; node->isVisible = false;
node->isDirty = false; /* See https://github.com/facebook/css-layout/issues/241 */
_CSSNodeMarkDirty(node); _CSSNodeMarkDirty(node);
} }
void CSSNodeShow(const CSSNodeRef node) { void CSSNodeShow(const CSSNodeRef node) {
node->isVisible = true; node->isVisible = true;
node->isDirty = false; /* See https://github.com/facebook/css-layout/issues/241 */
_CSSNodeMarkDirty(node); _CSSNodeMarkDirty(node);
} }
@@ -2198,12 +2200,16 @@ bool layoutNodeInternal(const CSSNodeRef node,
gDepth++; gDepth++;
#if 0 #if 0
printf("---\n");
printf("node->isDirty: %c\n", (node->isDirty) ? 'y' : 'n');
printf("layout->generationCount != gCurrentGenerationCount: %c\n", layout->generationCount != gCurrentGenerationCount ? 'y' : 'n');
printf("layout->lastParentDirection != parentDirection: %c\n", layout->lastParentDirection != parentDirection ? 'y' : 'n');
#endif
const bool needToVisitNode = const bool needToVisitNode =
(node->isDirty && layout->generationCount != gCurrentGenerationCount) || (node->isDirty && layout->generationCount != gCurrentGenerationCount) ||
layout->lastParentDirection != parentDirection; layout->lastParentDirection != parentDirection;
#else
const bool needToVisitNode = true;
#endif
if (needToVisitNode) { if (needToVisitNode) {
// Invalidate the cached results. // Invalidate the cached results.