DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

position: absolute should respect cross padding

Browse Source
This commit is contained in:
Christopher Chedeau
2014-04-21 17:31:04 -07:00
parent d5b5ccf56b
commit 39cc1e9b01
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Layout.js
View File

@@ -276,6 +276,8 @@ var computeLayout = (function() {
} }
} }
child.layout[pos[crossAxis]] += leadingCrossDim; child.layout[pos[crossAxis]] += leadingCrossDim;
} else {
child.layout[pos[crossAxis]] += getPadding(node, leading[crossAxis]);
} }
} }

14
src/__tests__/Layout-test.js
View File

@@ -535,6 +535,17 @@ describe('Layout', function() {
); );
}); });
it('should layout node with specified width', function() {
testLayout(
{style: {padding: 5}, children: [
{style: {position: 'absolute'}}
]},
{width: 10, height: 10, top: 0, left: 0, children: [
{width: 0, height: 0, top: 5, left: 5}
]}
);
});
it('should layout randomly', function() { it('should layout randomly', function() {
function RNG(seed) { function RNG(seed) {
this.state = seed; this.state = seed;
@@ -556,9 +567,6 @@ describe('Layout', function() {
} }
function randEnum(node, chance, attribute, enumValues) { function randEnum(node, chance, attribute, enumValues) {
if (rng.nextFloat() < chance) { if (rng.nextFloat() < chance) {
if (attribute === 'position') {
return;
}
node.style[attribute] = enumValues[Math.floor(rng.nextFloat() * enumValues.length)]; node.style[attribute] = enumValues[Math.floor(rng.nextFloat() * enumValues.length)];
} }
} }