From 3fbd92bc3b7491c5d8443329c170aefdcbee14c5 Mon Sep 17 00:00:00 2001
From: Joe Vilches <joevilches@meta.com>
Date: Thu, 12 Oct 2023 16:22:27 -0700
Subject: [PATCH] No longer skip margin_start and margin_end row reverse tests

Summary: These are fixed now!

Reviewed By: NickGerleman

Differential Revision: D50200030

fbshipit-source-id: ac3e80e33d8c35440e342a10cfd3246161ee9018
---
 gentest/fixtures/YGFlexDirectionTest.html              | 6 ++----
 java/tests/com/facebook/yoga/YGFlexDirectionTest.java  | 2 --
 javascript/tests/generated/YGFlexDirectionTest.test.ts | 4 ++--
 tests/generated/YGFlexDirectionTest.cpp                | 4 ----
 4 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/gentest/fixtures/YGFlexDirectionTest.html b/gentest/fixtures/YGFlexDirectionTest.html
index 33ce4c1a..12583209 100644
--- a/gentest/fixtures/YGFlexDirectionTest.html
+++ b/gentest/fixtures/YGFlexDirectionTest.html
@@ -41,8 +41,7 @@
 </div>
 
 <!-- gentest.rb will swap margin-start to margin-left. This is needed to use YGEdgeStart instead of YGEdgeLeft in the generated tests -->
-<!-- TODO: Yoga flips marginStart and marginEnd with rowReverse direction -->
-<div id="flex_direction_row_reverse_margin_start" data-disabled="true" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-start: 100px;">
+<div id="flex_direction_row_reverse_margin_start" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-start: 100px;">
   <div style="width: 10px;"></div>
   <div style="width: 10px;"></div>
   <div style="width: 10px;"></div>
@@ -54,8 +53,7 @@
   <div style="width: 10px;"></div>
 </div>
 
-<!-- TODO: Yoga flips marginStart and marginEnd with rowReverse direction -->
-<div id="flex_direction_row_reverse_margin_end" data-disabled="true" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-end: 100px;">
+<div id="flex_direction_row_reverse_margin_end" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-end: 100px;">
   <div style="width: 10px;"></div>
   <div style="width: 10px;"></div>
   <div style="width: 10px;"></div>
diff --git a/java/tests/com/facebook/yoga/YGFlexDirectionTest.java b/java/tests/com/facebook/yoga/YGFlexDirectionTest.java
index acbc88b3..7efb1329 100644
--- a/java/tests/com/facebook/yoga/YGFlexDirectionTest.java
+++ b/java/tests/com/facebook/yoga/YGFlexDirectionTest.java
@@ -499,7 +499,6 @@ public class YGFlexDirectionTest {
   }
 
   @Test
-  @Ignore
   public void test_flex_direction_row_reverse_margin_start() {
     YogaConfig config = YogaConfigFactory.create();
     config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -638,7 +637,6 @@ public class YGFlexDirectionTest {
   }
 
   @Test
-  @Ignore
   public void test_flex_direction_row_reverse_margin_end() {
     YogaConfig config = YogaConfigFactory.create();
     config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
diff --git a/javascript/tests/generated/YGFlexDirectionTest.test.ts b/javascript/tests/generated/YGFlexDirectionTest.test.ts
index 631cdae4..926702b0 100644
--- a/javascript/tests/generated/YGFlexDirectionTest.test.ts
+++ b/javascript/tests/generated/YGFlexDirectionTest.test.ts
@@ -540,7 +540,7 @@ test('flex_direction_row_reverse_margin_left', () => {
     config.free();
   }
 });
-test.skip('flex_direction_row_reverse_margin_start', () => {
+test('flex_direction_row_reverse_margin_start', () => {
   const config = Yoga.Config.create();
   let root;
 
@@ -690,7 +690,7 @@ test('flex_direction_row_reverse_margin_right', () => {
     config.free();
   }
 });
-test.skip('flex_direction_row_reverse_margin_end', () => {
+test('flex_direction_row_reverse_margin_end', () => {
   const config = Yoga.Config.create();
   let root;
 
diff --git a/tests/generated/YGFlexDirectionTest.cpp b/tests/generated/YGFlexDirectionTest.cpp
index e0a9906c..8a1101c8 100644
--- a/tests/generated/YGFlexDirectionTest.cpp
+++ b/tests/generated/YGFlexDirectionTest.cpp
@@ -492,8 +492,6 @@ TEST(YogaTest, flex_direction_row_reverse_margin_left) {
 }
 
 TEST(YogaTest, flex_direction_row_reverse_margin_start) {
-  GTEST_SKIP();
-
   const YGConfigRef config = YGConfigNew();
   YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
 
@@ -634,8 +632,6 @@ TEST(YogaTest, flex_direction_row_reverse_margin_right) {
 }
 
 TEST(YogaTest, flex_direction_row_reverse_margin_end) {
-  GTEST_SKIP();
-
   const YGConfigRef config = YGConfigNew();
   YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);