DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Rename makeCriticalNativeMethod to discourage over-use

Browse Source 
Summary: "Critical" or "Fast" JNI methods are enticing by their name, but carry dangers that are not trivially visible.

Reviewed By: davidaurelio

Differential Revision: D14184560

fbshipit-source-id: 89ec70f53bb2cb89ff568d8b1fe222ede86c9824
This commit is contained in:
Chris Sarbora
2019-02-22 14:17:05 -08:00
committed by Facebook Github Bot
parent 95169c3150
commit 47abe1c482
3 changed files with 69 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/jni/YGJNI.cpp
View File

@@ -719,7 +719,7 @@ jint jni_YGNodeGetInstanceCount() {
}
#define YGMakeNativeMethod(name) makeNativeMethod(#name, name)
#define YGMakeCriticalNativeMethod(name) makeCriticalNativeMethod(#name, name)
#define YGMakeCriticalNativeMethod(name) makeCriticalNativeMethod_DO_NOT_USE_OR_YOU_WILL_BE_FIRED(#name, name)
jint JNI_OnLoad(JavaVM* vm, void*) {
return initialize(vm, [] {