DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix misc-misplaced-const warnings in Yoga tests (#1677)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1677

We have Clang Tidy warnings enabled internally, that will flag `const YG*Ref` as misleading, as a const pointer to non-const, instead of non-const pointer to const.

Let's remove all the misleading const in existing tests, and generated tests.

Reviewed By: joevilches

Differential Revision: D59335968

fbshipit-source-id: c66af878904ba7900f8ffcd99162968d90f8e5c7
This commit is contained in:
Nick Gerleman
2024-07-03 17:30:10 -07:00
committed by Facebook GitHub Bot
parent e4fe14ab3e
commit 5009f5c1ac
44 changed files with 2785 additions and 2797 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/YGZeroOutLayoutRecursivelyTest.cpp
View File

@@ -9,12 +9,12 @@
#include <yoga/Yoga.h>
TEST(YogaTest, zero_out_layout) {
const YGNodeRef root = YGNodeNew();
YGNodeRef root = YGNodeNew();
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
YGNodeStyleSetWidth(root, 200);
YGNodeStyleSetHeight(root, 200);
const YGNodeRef child = YGNodeNew();
YGNodeRef child = YGNodeNew();
YGNodeInsertChild(root, child, 0);
YGNodeStyleSetWidth(child, 100);
YGNodeStyleSetHeight(child, 100);