Fix misc-misplaced-const warnings in Yoga tests (#1677)
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1677 We have Clang Tidy warnings enabled internally, that will flag `const YG*Ref` as misleading, as a const pointer to non-const, instead of non-const pointer to const. Let's remove all the misleading const in existing tests, and generated tests. Reviewed By: joevilches Differential Revision: D59335968 fbshipit-source-id: c66af878904ba7900f8ffcd99162968d90f8e5c7
This commit is contained in:
Nick Gerleman
committed by
Facebook GitHub Bot
Facebook GitHub Bot
parent
e4fe14ab3e
commit
5009f5c1ac
@@ -5,7 +5,7 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* clang-format off
|
||||
* @generated SignedSource<<9dc8f0d4029732bc8849ded9af8b82dc>>
|
||||
* @generated SignedSource<<98875d3d64ab8d1a568e81773281be5c>>
|
||||
* generated by gentest/gentest-driver.ts from gentest/fixtures/YGAndroidNewsFeed.html
|
||||
*/
|
||||
|
||||
@@ -14,25 +14,25 @@
|
||||
#include "../util/TestUtil.h"
|
||||
|
||||
TEST(YogaTest, android_news_feed) {
|
||||
const YGConfigRef config = YGConfigNew();
|
||||
YGConfigRef config = YGConfigNew();
|
||||
|
||||
const YGNodeRef root = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root, YGAlignStretch);
|
||||
YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute);
|
||||
YGNodeStyleSetWidth(root, 1080);
|
||||
|
||||
const YGNodeRef root_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeInsertChild(root, root_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0, YGAlignStretch);
|
||||
YGNodeInsertChild(root_child0, root_child0_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child0, YGAlignStretch);
|
||||
YGNodeInsertChild(root_child0_child0, root_child0_child0_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetFlexDirection(root_child0_child0_child0_child0, YGFlexDirectionRow);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child0_child0, YGAlignStretch);
|
||||
YGNodeStyleSetAlignItems(root_child0_child0_child0_child0, YGAlignFlexStart);
|
||||
@@ -40,18 +40,18 @@ TEST(YogaTest, android_news_feed) {
|
||||
YGNodeStyleSetMargin(root_child0_child0_child0_child0, YGEdgeTop, 24);
|
||||
YGNodeInsertChild(root_child0_child0_child0, root_child0_child0_child0_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetFlexDirection(root_child0_child0_child0_child0_child0, YGFlexDirectionRow);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child0_child0_child0, YGAlignStretch);
|
||||
YGNodeInsertChild(root_child0_child0_child0_child0, root_child0_child0_child0_child0_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child0_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child0_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child0_child0_child0_child0, YGAlignStretch);
|
||||
YGNodeStyleSetWidth(root_child0_child0_child0_child0_child0_child0, 120);
|
||||
YGNodeStyleSetHeight(root_child0_child0_child0_child0_child0_child0, 120);
|
||||
YGNodeInsertChild(root_child0_child0_child0_child0_child0, root_child0_child0_child0_child0_child0_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child0_child0_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child0_child0_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child0_child0_child1, YGAlignStretch);
|
||||
YGNodeStyleSetFlexShrink(root_child0_child0_child0_child0_child1, 1);
|
||||
YGNodeStyleSetMargin(root_child0_child0_child0_child0_child1, YGEdgeRight, 36);
|
||||
@@ -61,22 +61,22 @@ TEST(YogaTest, android_news_feed) {
|
||||
YGNodeStyleSetPadding(root_child0_child0_child0_child0_child1, YGEdgeBottom, 18);
|
||||
YGNodeInsertChild(root_child0_child0_child0_child0, root_child0_child0_child0_child0_child1, 1);
|
||||
|
||||
const YGNodeRef root_child0_child0_child0_child0_child1_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child0_child0_child1_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetFlexDirection(root_child0_child0_child0_child0_child1_child0, YGFlexDirectionRow);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child0_child0_child1_child0, YGAlignStretch);
|
||||
YGNodeStyleSetFlexShrink(root_child0_child0_child0_child0_child1_child0, 1);
|
||||
YGNodeInsertChild(root_child0_child0_child0_child0_child1, root_child0_child0_child0_child0_child1_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child0_child0_child1_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child0_child0_child1_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child0_child0_child1_child1, YGAlignStretch);
|
||||
YGNodeStyleSetFlexShrink(root_child0_child0_child0_child0_child1_child1, 1);
|
||||
YGNodeInsertChild(root_child0_child0_child0_child0_child1, root_child0_child0_child0_child0_child1_child1, 1);
|
||||
|
||||
const YGNodeRef root_child0_child0_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child1, YGAlignStretch);
|
||||
YGNodeInsertChild(root_child0_child0, root_child0_child0_child1, 1);
|
||||
|
||||
const YGNodeRef root_child0_child0_child1_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child1_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetFlexDirection(root_child0_child0_child1_child0, YGFlexDirectionRow);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child1_child0, YGAlignStretch);
|
||||
YGNodeStyleSetAlignItems(root_child0_child0_child1_child0, YGAlignFlexStart);
|
||||
@@ -84,18 +84,18 @@ TEST(YogaTest, android_news_feed) {
|
||||
YGNodeStyleSetMargin(root_child0_child0_child1_child0, YGEdgeTop, 24);
|
||||
YGNodeInsertChild(root_child0_child0_child1, root_child0_child0_child1_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child1_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child1_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetFlexDirection(root_child0_child0_child1_child0_child0, YGFlexDirectionRow);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child1_child0_child0, YGAlignStretch);
|
||||
YGNodeInsertChild(root_child0_child0_child1_child0, root_child0_child0_child1_child0_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child1_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child1_child0_child0_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child1_child0_child0_child0, YGAlignStretch);
|
||||
YGNodeStyleSetWidth(root_child0_child0_child1_child0_child0_child0, 72);
|
||||
YGNodeStyleSetHeight(root_child0_child0_child1_child0_child0_child0, 72);
|
||||
YGNodeInsertChild(root_child0_child0_child1_child0_child0, root_child0_child0_child1_child0_child0_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child1_child0_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child1_child0_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child1_child0_child1, YGAlignStretch);
|
||||
YGNodeStyleSetFlexShrink(root_child0_child0_child1_child0_child1, 1);
|
||||
YGNodeStyleSetMargin(root_child0_child0_child1_child0_child1, YGEdgeRight, 36);
|
||||
@@ -105,13 +105,13 @@ TEST(YogaTest, android_news_feed) {
|
||||
YGNodeStyleSetPadding(root_child0_child0_child1_child0_child1, YGEdgeBottom, 18);
|
||||
YGNodeInsertChild(root_child0_child0_child1_child0, root_child0_child0_child1_child0_child1, 1);
|
||||
|
||||
const YGNodeRef root_child0_child0_child1_child0_child1_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child1_child0_child1_child0 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetFlexDirection(root_child0_child0_child1_child0_child1_child0, YGFlexDirectionRow);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child1_child0_child1_child0, YGAlignStretch);
|
||||
YGNodeStyleSetFlexShrink(root_child0_child0_child1_child0_child1_child0, 1);
|
||||
YGNodeInsertChild(root_child0_child0_child1_child0_child1, root_child0_child0_child1_child0_child1_child0, 0);
|
||||
|
||||
const YGNodeRef root_child0_child0_child1_child0_child1_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeRef root_child0_child0_child1_child0_child1_child1 = YGNodeNewWithConfig(config);
|
||||
YGNodeStyleSetAlignContent(root_child0_child0_child1_child0_child1_child1, YGAlignStretch);
|
||||
YGNodeStyleSetFlexShrink(root_child0_child0_child1_child0_child1_child1, 1);
|
||||
YGNodeInsertChild(root_child0_child0_child1_child0_child1, root_child0_child0_child1_child0_child1_child1, 1);
|
||||
|
||||
Reference in New Issue
Block a user