DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add back deprecated getParent methods for non-breaking API change (#775)

Browse Source 
Summary:
I'm not totally sure what I'm doing so if this needs changes let me know.
Closes https://github.com/facebook/yoga/pull/775

Reviewed By: emilsjolander

Differential Revision: D8331892

Pulled By: passy

fbshipit-source-id: eb1023e666322d2472e4081fd4a4e72a7b43d049
This commit is contained in:
Vince Mi
2018-06-11 04:07:38 -07:00
committed by Facebook Github Bot
parent b47f0ce41a
commit 526ca42d04
5 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/com/facebook/yoga/YogaNode.java
View File

@@ -234,15 +234,14 @@ public class YogaNode implements Cloneable {
* {@link YogaNode} is shared between two or more YogaTrees. * {@link YogaNode} is shared between two or more YogaTrees.
*/ */
@Nullable @Nullable
public public YogaNode getOwner() {
YogaNode getOwner() {
return mOwner; return mOwner;
} }
/** @deprecated Use #getOwner() instead. This will be removed in the next version. */ /** @deprecated Use #getOwner() instead. This will be removed in the next version. */
@Deprecated @Deprecated
@Nullable @Nullable
YogaNode getParent() { public YogaNode getParent() {
return getOwner(); return getOwner();
} }

4
yoga/YGNode.cpp
View File

@@ -53,6 +53,10 @@ YGNodeRef YGNode::getOwner() const {
return owner_; return owner_;
} }
YGNodeRef YGNode::getParent() const {
return getOwner();
}
YGVector YGNode::getChildren() const { YGVector YGNode::getChildren() const {
return children_; return children_;
} }

2
yoga/YGNode.h
View File

@@ -78,6 +78,8 @@ struct YGNode {
// to one YogaTree or nullptr when the YGNode is shared between two or more // to one YogaTree or nullptr when the YGNode is shared between two or more
// YogaTrees. // YogaTrees.
YGNodeRef getOwner() const; YGNodeRef getOwner() const;
// Deprecated, use getOwner() instead.
YGNodeRef getParent() const;
YGVector getChildren() const; YGVector getChildren() const;
uint32_t getChildrenCount() const; uint32_t getChildrenCount() const;
YGNodeRef getChild(uint32_t index) const; YGNodeRef getChild(uint32_t index) const;

4
yoga/Yoga.cpp
View File

@@ -535,6 +535,10 @@ YGNodeRef YGNodeGetOwner(const YGNodeRef node) {
return node->getOwner(); return node->getOwner();
} }
YGNodeRef YGNodeGetParent(const YGNodeRef node) {
return node->getOwner();
}
void YGNodeMarkDirty(const YGNodeRef node) { void YGNodeMarkDirty(const YGNodeRef node) {
YGAssertWithNode( YGAssertWithNode(
node, node,

1
yoga/Yoga.h
View File

@@ -92,6 +92,7 @@ WIN_EXPORT void YGNodeRemoveChild(const YGNodeRef node, const YGNodeRef child);
WIN_EXPORT void YGNodeRemoveAllChildren(const YGNodeRef node); WIN_EXPORT void YGNodeRemoveAllChildren(const YGNodeRef node);
WIN_EXPORT YGNodeRef YGNodeGetChild(const YGNodeRef node, const uint32_t index); WIN_EXPORT YGNodeRef YGNodeGetChild(const YGNodeRef node, const uint32_t index);
WIN_EXPORT YGNodeRef YGNodeGetOwner(const YGNodeRef node); WIN_EXPORT YGNodeRef YGNodeGetOwner(const YGNodeRef node);
WIN_EXPORT YGNodeRef YGNodeGetParent(const YGNodeRef node);
WIN_EXPORT uint32_t YGNodeGetChildCount(const YGNodeRef node); WIN_EXPORT uint32_t YGNodeGetChildCount(const YGNodeRef node);
WIN_EXPORT void YGNodeSetChildren( WIN_EXPORT void YGNodeSetChildren(
YGNodeRef const owner, YGNodeRef const owner,