From 56e133ab4c7966c0d61c0335b59beeb589d7a223 Mon Sep 17 00:00:00 2001 From: Taras Tsugrii Date: Wed, 19 Dec 2018 15:12:27 -0800 Subject: [PATCH] Do not use glob for static paths. Summary: ``` >>> Lint for xplat/yoga/csharp/BUCK: Warning (BUILDIFIERLINT2) constant-glob Glob pattern `Yoga/YGInterop.cpp` has no wildcard ('*'). Constant patterns can be error-prone, move the file outside the glob. (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#constant-glob) 30 31 yoga_cxx_library( 32 name = "yoganet", >>> 33 srcs = glob(["Yoga/YGInterop.cpp"]), 34 compiler_flags = COMPILER_FLAGS, 35 link_style = "static", 36 link_whole = True, ``` Differential Revision: D13521382 fbshipit-source-id: 744368e7818370c8ec68f332caaf766cad635e7a --- csharp/BUCK | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csharp/BUCK b/csharp/BUCK index 0f8a0bf8..0df9bea4 100644 --- a/csharp/BUCK +++ b/csharp/BUCK @@ -30,7 +30,7 @@ fb_native.csharp_library( yoga_cxx_library( name = "yoganet", - srcs = glob(["Yoga/YGInterop.cpp"]), + srcs = ["Yoga/YGInterop.cpp"], compiler_flags = COMPILER_FLAGS, link_style = "static", link_whole = True,