From 5f8703f345dd2507ebe229eba92ef3d98160d79a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20W=C3=B6hrl?= Date: Sun, 12 Mar 2017 17:51:05 +0100 Subject: [PATCH] remove not required position absolute from tests --- csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs | 4 ---- csharp/tests/Facebook.Yoga/YGMarginTest.cs | 4 ---- gentest/fixtures/YGAlignItemsTest.html | 8 ++++---- gentest/fixtures/YGMarginTest.html | 8 ++++---- java/tests/com/facebook/yoga/YGAlignItemsTest.java | 4 ---- java/tests/com/facebook/yoga/YGMarginTest.java | 4 ---- javascript/tests/Facebook.Yoga/YGAlignItemsTest.js | 4 ---- javascript/tests/Facebook.Yoga/YGMarginTest.js | 4 ---- tests/YGAlignItemsTest.cpp | 4 ---- tests/YGMarginTest.cpp | 4 ---- 10 files changed, 8 insertions(+), 40 deletions(-) diff --git a/csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs b/csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs index 4d0dbd7d..7b150568 100644 --- a/csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs +++ b/csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs @@ -1595,7 +1595,6 @@ namespace Facebook.Yoga YogaNode root = new YogaNode(config); root.JustifyContent = YogaJustify.Center; root.AlignItems = YogaAlign.Center; - root.PositionType = YogaPositionType.Absolute; root.Width = 52; root.Height = 52; @@ -1654,7 +1653,6 @@ namespace Facebook.Yoga YogaNode root = new YogaNode(config); root.JustifyContent = YogaJustify.Center; root.AlignItems = YogaAlign.Center; - root.PositionType = YogaPositionType.Absolute; root.Width = 52; root.Height = 52; @@ -1713,7 +1711,6 @@ namespace Facebook.Yoga YogaNode root = new YogaNode(config); root.JustifyContent = YogaJustify.Center; root.AlignItems = YogaAlign.Center; - root.PositionType = YogaPositionType.Absolute; root.Width = 52; root.Height = 52; @@ -1770,7 +1767,6 @@ namespace Facebook.Yoga YogaNode root = new YogaNode(config); root.JustifyContent = YogaJustify.Center; root.AlignItems = YogaAlign.Center; - root.PositionType = YogaPositionType.Absolute; root.Width = 52; root.Height = 52; diff --git a/csharp/tests/Facebook.Yoga/YGMarginTest.cs b/csharp/tests/Facebook.Yoga/YGMarginTest.cs index 15177ec3..965cfc78 100644 --- a/csharp/tests/Facebook.Yoga/YGMarginTest.cs +++ b/csharp/tests/Facebook.Yoga/YGMarginTest.cs @@ -1443,7 +1443,6 @@ namespace Facebook.Yoga YogaNode root = new YogaNode(config); root.JustifyContent = YogaJustify.Center; - root.PositionType = YogaPositionType.Absolute; root.Width = 52; root.Height = 52; @@ -1487,7 +1486,6 @@ namespace Facebook.Yoga YogaNode root = new YogaNode(config); root.JustifyContent = YogaJustify.Center; - root.PositionType = YogaPositionType.Absolute; root.Width = 52; root.Height = 52; @@ -1530,7 +1528,6 @@ namespace Facebook.Yoga YogaNode root = new YogaNode(config); root.JustifyContent = YogaJustify.Center; - root.PositionType = YogaPositionType.Absolute; root.Width = 52; root.Height = 52; @@ -1574,7 +1571,6 @@ namespace Facebook.Yoga YogaNode root = new YogaNode(config); root.JustifyContent = YogaJustify.Center; - root.PositionType = YogaPositionType.Absolute; root.Width = 52; root.Height = 52; diff --git a/gentest/fixtures/YGAlignItemsTest.html b/gentest/fixtures/YGAlignItemsTest.html index b11e0f86..2c88c306 100644 --- a/gentest/fixtures/YGAlignItemsTest.html +++ b/gentest/fixtures/YGAlignItemsTest.html @@ -144,25 +144,25 @@
-
+
-
+
-
+
-
+
diff --git a/gentest/fixtures/YGMarginTest.html b/gentest/fixtures/YGMarginTest.html index 14aeb3d0..ac7a2aa9 100644 --- a/gentest/fixtures/YGMarginTest.html +++ b/gentest/fixtures/YGMarginTest.html @@ -125,18 +125,18 @@
-
+
-
+
-
+
-
+
diff --git a/java/tests/com/facebook/yoga/YGAlignItemsTest.java b/java/tests/com/facebook/yoga/YGAlignItemsTest.java index f581e34c..cea82fb5 100644 --- a/java/tests/com/facebook/yoga/YGAlignItemsTest.java +++ b/java/tests/com/facebook/yoga/YGAlignItemsTest.java @@ -1574,7 +1574,6 @@ public class YGAlignItemsTest { final YogaNode root = new YogaNode(config); root.setJustifyContent(YogaJustify.CENTER); root.setAlignItems(YogaAlign.CENTER); - root.setPositionType(YogaPositionType.ABSOLUTE); root.setWidth(52f); root.setHeight(52f); @@ -1632,7 +1631,6 @@ public class YGAlignItemsTest { final YogaNode root = new YogaNode(config); root.setJustifyContent(YogaJustify.CENTER); root.setAlignItems(YogaAlign.CENTER); - root.setPositionType(YogaPositionType.ABSOLUTE); root.setWidth(52f); root.setHeight(52f); @@ -1690,7 +1688,6 @@ public class YGAlignItemsTest { final YogaNode root = new YogaNode(config); root.setJustifyContent(YogaJustify.CENTER); root.setAlignItems(YogaAlign.CENTER); - root.setPositionType(YogaPositionType.ABSOLUTE); root.setWidth(52f); root.setHeight(52f); @@ -1746,7 +1743,6 @@ public class YGAlignItemsTest { final YogaNode root = new YogaNode(config); root.setJustifyContent(YogaJustify.CENTER); root.setAlignItems(YogaAlign.CENTER); - root.setPositionType(YogaPositionType.ABSOLUTE); root.setWidth(52f); root.setHeight(52f); diff --git a/java/tests/com/facebook/yoga/YGMarginTest.java b/java/tests/com/facebook/yoga/YGMarginTest.java index f0d137f2..fe7a9518 100644 --- a/java/tests/com/facebook/yoga/YGMarginTest.java +++ b/java/tests/com/facebook/yoga/YGMarginTest.java @@ -1414,7 +1414,6 @@ public class YGMarginTest { final YogaNode root = new YogaNode(config); root.setJustifyContent(YogaJustify.CENTER); - root.setPositionType(YogaPositionType.ABSOLUTE); root.setWidth(52f); root.setHeight(52f); @@ -1457,7 +1456,6 @@ public class YGMarginTest { final YogaNode root = new YogaNode(config); root.setJustifyContent(YogaJustify.CENTER); - root.setPositionType(YogaPositionType.ABSOLUTE); root.setWidth(52f); root.setHeight(52f); @@ -1499,7 +1497,6 @@ public class YGMarginTest { final YogaNode root = new YogaNode(config); root.setJustifyContent(YogaJustify.CENTER); - root.setPositionType(YogaPositionType.ABSOLUTE); root.setWidth(52f); root.setHeight(52f); @@ -1542,7 +1539,6 @@ public class YGMarginTest { final YogaNode root = new YogaNode(config); root.setJustifyContent(YogaJustify.CENTER); - root.setPositionType(YogaPositionType.ABSOLUTE); root.setWidth(52f); root.setHeight(52f); diff --git a/javascript/tests/Facebook.Yoga/YGAlignItemsTest.js b/javascript/tests/Facebook.Yoga/YGAlignItemsTest.js index baa8e595..edd37885 100644 --- a/javascript/tests/Facebook.Yoga/YGAlignItemsTest.js +++ b/javascript/tests/Facebook.Yoga/YGAlignItemsTest.js @@ -1567,7 +1567,6 @@ it("align_items_center_child_with_margin_bigger_than_parent", function () { var root = Yoga.Node.create(config); root.setJustifyContent(Yoga.JUSTIFY_CENTER); root.setAlignItems(Yoga.ALIGN_CENTER); - root.setPositionType(Yoga.POSITION_TYPE_ABSOLUTE); root.setWidth(52); root.setHeight(52); @@ -1625,7 +1624,6 @@ it("align_items_flex_end_child_with_margin_bigger_than_parent", function () { var root = Yoga.Node.create(config); root.setJustifyContent(Yoga.JUSTIFY_CENTER); root.setAlignItems(Yoga.ALIGN_CENTER); - root.setPositionType(Yoga.POSITION_TYPE_ABSOLUTE); root.setWidth(52); root.setHeight(52); @@ -1683,7 +1681,6 @@ it("align_items_center_child_without_margin_bigger_than_parent", function () { var root = Yoga.Node.create(config); root.setJustifyContent(Yoga.JUSTIFY_CENTER); root.setAlignItems(Yoga.ALIGN_CENTER); - root.setPositionType(Yoga.POSITION_TYPE_ABSOLUTE); root.setWidth(52); root.setHeight(52); @@ -1739,7 +1736,6 @@ it("align_items_flex_end_child_without_margin_bigger_than_parent", function () { var root = Yoga.Node.create(config); root.setJustifyContent(Yoga.JUSTIFY_CENTER); root.setAlignItems(Yoga.ALIGN_CENTER); - root.setPositionType(Yoga.POSITION_TYPE_ABSOLUTE); root.setWidth(52); root.setHeight(52); diff --git a/javascript/tests/Facebook.Yoga/YGMarginTest.js b/javascript/tests/Facebook.Yoga/YGMarginTest.js index 2e486290..0ed2f1ca 100644 --- a/javascript/tests/Facebook.Yoga/YGMarginTest.js +++ b/javascript/tests/Facebook.Yoga/YGMarginTest.js @@ -1407,7 +1407,6 @@ it("margin_auto_left_right_child_bigger_than_parent", function () { try { var root = Yoga.Node.create(config); root.setJustifyContent(Yoga.JUSTIFY_CENTER); - root.setPositionType(Yoga.POSITION_TYPE_ABSOLUTE); root.setWidth(52); root.setHeight(52); @@ -1450,7 +1449,6 @@ it("margin_auto_left_child_bigger_than_parent", function () { try { var root = Yoga.Node.create(config); root.setJustifyContent(Yoga.JUSTIFY_CENTER); - root.setPositionType(Yoga.POSITION_TYPE_ABSOLUTE); root.setWidth(52); root.setHeight(52); @@ -1492,7 +1490,6 @@ it("margin_fix_left_auto_right_child_bigger_than_parent", function () { try { var root = Yoga.Node.create(config); root.setJustifyContent(Yoga.JUSTIFY_CENTER); - root.setPositionType(Yoga.POSITION_TYPE_ABSOLUTE); root.setWidth(52); root.setHeight(52); @@ -1535,7 +1532,6 @@ it("margin_auto_left_fix_right_child_bigger_than_parent", function () { try { var root = Yoga.Node.create(config); root.setJustifyContent(Yoga.JUSTIFY_CENTER); - root.setPositionType(Yoga.POSITION_TYPE_ABSOLUTE); root.setWidth(52); root.setHeight(52); diff --git a/tests/YGAlignItemsTest.cpp b/tests/YGAlignItemsTest.cpp index 268b6343..8fe2deff 100644 --- a/tests/YGAlignItemsTest.cpp +++ b/tests/YGAlignItemsTest.cpp @@ -1588,7 +1588,6 @@ TEST(YogaTest, align_items_center_child_with_margin_bigger_than_parent) { const YGNodeRef root = YGNodeNewWithConfig(config); YGNodeStyleSetJustifyContent(root, YGJustifyCenter); YGNodeStyleSetAlignItems(root, YGAlignCenter); - YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute); YGNodeStyleSetWidth(root, 52); YGNodeStyleSetHeight(root, 52); @@ -1647,7 +1646,6 @@ TEST(YogaTest, align_items_flex_end_child_with_margin_bigger_than_parent) { const YGNodeRef root = YGNodeNewWithConfig(config); YGNodeStyleSetJustifyContent(root, YGJustifyCenter); YGNodeStyleSetAlignItems(root, YGAlignCenter); - YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute); YGNodeStyleSetWidth(root, 52); YGNodeStyleSetHeight(root, 52); @@ -1706,7 +1704,6 @@ TEST(YogaTest, align_items_center_child_without_margin_bigger_than_parent) { const YGNodeRef root = YGNodeNewWithConfig(config); YGNodeStyleSetJustifyContent(root, YGJustifyCenter); YGNodeStyleSetAlignItems(root, YGAlignCenter); - YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute); YGNodeStyleSetWidth(root, 52); YGNodeStyleSetHeight(root, 52); @@ -1763,7 +1760,6 @@ TEST(YogaTest, align_items_flex_end_child_without_margin_bigger_than_parent) { const YGNodeRef root = YGNodeNewWithConfig(config); YGNodeStyleSetJustifyContent(root, YGJustifyCenter); YGNodeStyleSetAlignItems(root, YGAlignCenter); - YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute); YGNodeStyleSetWidth(root, 52); YGNodeStyleSetHeight(root, 52); diff --git a/tests/YGMarginTest.cpp b/tests/YGMarginTest.cpp index 28208f96..a7ff069f 100644 --- a/tests/YGMarginTest.cpp +++ b/tests/YGMarginTest.cpp @@ -1436,7 +1436,6 @@ TEST(YogaTest, margin_auto_left_right_child_bigger_than_parent) { const YGNodeRef root = YGNodeNewWithConfig(config); YGNodeStyleSetJustifyContent(root, YGJustifyCenter); - YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute); YGNodeStyleSetWidth(root, 52); YGNodeStyleSetHeight(root, 52); @@ -1480,7 +1479,6 @@ TEST(YogaTest, margin_auto_left_child_bigger_than_parent) { const YGNodeRef root = YGNodeNewWithConfig(config); YGNodeStyleSetJustifyContent(root, YGJustifyCenter); - YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute); YGNodeStyleSetWidth(root, 52); YGNodeStyleSetHeight(root, 52); @@ -1523,7 +1521,6 @@ TEST(YogaTest, margin_fix_left_auto_right_child_bigger_than_parent) { const YGNodeRef root = YGNodeNewWithConfig(config); YGNodeStyleSetJustifyContent(root, YGJustifyCenter); - YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute); YGNodeStyleSetWidth(root, 52); YGNodeStyleSetHeight(root, 52); @@ -1567,7 +1564,6 @@ TEST(YogaTest, margin_auto_left_fix_right_child_bigger_than_parent) { const YGNodeRef root = YGNodeNewWithConfig(config); YGNodeStyleSetJustifyContent(root, YGJustifyCenter); - YGNodeStyleSetPositionType(root, YGPositionTypeAbsolute); YGNodeStyleSetWidth(root, 52); YGNodeStyleSetHeight(root, 52);