diff --git a/java/jni/ScopedGlobalRef.h b/java/jni/ScopedGlobalRef.h index 64ca74dc..fa0afba2 100644 --- a/java/jni/ScopedGlobalRef.h +++ b/java/jni/ScopedGlobalRef.h @@ -12,9 +12,7 @@ #include #include "corefunctions.h" -namespace facebook { -namespace yoga { -namespace vanillajni { +namespace facebook::yoga::vanillajni { /** * ScopedGlobalRef is a sort of smart reference that allows us to control the @@ -132,6 +130,4 @@ ScopedGlobalRef make_global_ref(T globalRef) { return ScopedGlobalRef(globalRef); } -} // namespace vanillajni -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::vanillajni diff --git a/java/jni/ScopedLocalRef.h b/java/jni/ScopedLocalRef.h index 56c4d101..e486e204 100644 --- a/java/jni/ScopedLocalRef.h +++ b/java/jni/ScopedLocalRef.h @@ -15,9 +15,7 @@ #include #include -namespace facebook { -namespace yoga { -namespace vanillajni { +namespace facebook::yoga::vanillajni { /** * ScopedLocalRef is a sort of smart reference that allows us to control the @@ -132,6 +130,4 @@ ScopedLocalRef make_local_ref(JNIEnv* env, T localRef) { return ScopedLocalRef(env, localRef); } -} // namespace vanillajni -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::vanillajni diff --git a/java/jni/YogaJniException.cpp b/java/jni/YogaJniException.cpp index 81bdf28f..aabbc753 100644 --- a/java/jni/YogaJniException.cpp +++ b/java/jni/YogaJniException.cpp @@ -10,9 +10,7 @@ #include "YogaJniException.h" #include "common.h" -namespace facebook { -namespace yoga { -namespace vanillajni { +namespace facebook::yoga::vanillajni { YogaJniException::YogaJniException() { jclass cl = getCurrentEnv()->FindClass("java/lang/RuntimeException"); @@ -47,6 +45,5 @@ ScopedLocalRef YogaJniException::getThrowable() const noexcept { getCurrentEnv(), static_cast(getCurrentEnv()->NewLocalRef(throwable_.get()))); } -} // namespace vanillajni -} // namespace yoga -} // namespace facebook + +} // namespace facebook::yoga::vanillajni diff --git a/java/jni/YogaJniException.h b/java/jni/YogaJniException.h index b0378ab4..7c858b5a 100644 --- a/java/jni/YogaJniException.h +++ b/java/jni/YogaJniException.h @@ -9,9 +9,7 @@ #include #include "common.h" -namespace facebook { -namespace yoga { -namespace vanillajni { +namespace facebook::yoga::vanillajni { /** * This class wraps a Java exception (jthrowable) into a C++ exception; A global * reference to Java exception (jthrowable) is made so that the exception object @@ -33,6 +31,5 @@ public: private: ScopedGlobalRef throwable_; }; -} // namespace vanillajni -} // namespace yoga -} // namespace facebook + +} // namespace facebook::yoga::vanillajni diff --git a/java/jni/common.cpp b/java/jni/common.cpp index e8ece68a..f7a43175 100644 --- a/java/jni/common.cpp +++ b/java/jni/common.cpp @@ -7,9 +7,7 @@ #include "common.h" -namespace facebook { -namespace yoga { -namespace vanillajni { +namespace facebook::yoga::vanillajni { void registerNatives( JNIEnv* env, @@ -109,6 +107,5 @@ ScopedGlobalRef newGlobalRef(JNIEnv* env, jthrowable obj) { return make_global_ref(result); } -} // namespace vanillajni -} // namespace yoga -} // namespace facebook + +} // namespace facebook::yoga::vanillajni diff --git a/java/jni/common.h b/java/jni/common.h index d79c3e50..57631618 100644 --- a/java/jni/common.h +++ b/java/jni/common.h @@ -9,9 +9,7 @@ #include "ScopedGlobalRef.h" #include "ScopedLocalRef.h" -namespace facebook { -namespace yoga { -namespace vanillajni { +namespace facebook::yoga::vanillajni { /** * Registers a set of methods for a JNI class. Aborts if registration fails. @@ -74,6 +72,5 @@ ScopedLocalRef callStaticObjectMethod( ScopedGlobalRef newGlobalRef(JNIEnv* env, jobject obj); ScopedGlobalRef newGlobalRef(JNIEnv* env, jthrowable obj); -} // namespace vanillajni -} // namespace yoga -} // namespace facebook + +} // namespace facebook::yoga::vanillajni diff --git a/java/jni/corefunctions.cpp b/java/jni/corefunctions.cpp index bbdcebd3..bcaf8119 100644 --- a/java/jni/corefunctions.cpp +++ b/java/jni/corefunctions.cpp @@ -9,9 +9,7 @@ #include "macros.h" #include "YogaJniException.h" -namespace facebook { -namespace yoga { -namespace vanillajni { +namespace facebook::yoga::vanillajni { namespace { JavaVM* globalVm = NULL; @@ -90,6 +88,4 @@ void assertNoPendingJniExceptionIf(JNIEnv* env, bool condition) { throw YogaJniException(); } -} // namespace vanillajni -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::vanillajni diff --git a/java/jni/corefunctions.h b/java/jni/corefunctions.h index e6f2650e..ced9480b 100644 --- a/java/jni/corefunctions.h +++ b/java/jni/corefunctions.h @@ -10,9 +10,7 @@ #include #include -namespace facebook { -namespace yoga { -namespace vanillajni { +namespace facebook::yoga::vanillajni { /** * This method has to be called before using the vanillajni library. This method @@ -49,6 +47,4 @@ void assertNoPendingJniException(JNIEnv* env); void assertNoPendingJniExceptionIf(JNIEnv* env, bool condition); -} // namespace vanillajni -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::vanillajni diff --git a/tests/BitUtilsTest.cpp b/tests/BitUtilsTest.cpp index 15be7f96..211a155c 100644 --- a/tests/BitUtilsTest.cpp +++ b/tests/BitUtilsTest.cpp @@ -10,8 +10,7 @@ #include #include -namespace facebook { -namespace yoga { +namespace facebook::yoga { TEST(BitUtils, one_boolean_defaults_to_false) { constexpr uint8_t flags = 0; @@ -202,5 +201,4 @@ TEST(BitUtils, setting_values_does_not_spill_over) { ASSERT_EQ(detail::getEnumData(flags, edgesOffset), 0xf); } -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga diff --git a/tests/EventsTest.cpp b/tests/EventsTest.cpp index 78e73459..648d844d 100644 --- a/tests/EventsTest.cpp +++ b/tests/EventsTest.cpp @@ -18,9 +18,7 @@ #include "util/TestUtil.h" -namespace facebook { -namespace yoga { -namespace test { +namespace facebook::yoga::test { template struct TypedEventTestData {}; @@ -353,6 +351,4 @@ void EventTest::TearDown() { std::vector EventTest::events{}; -} // namespace test -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::test diff --git a/tests/YGStyleAccessorsTest.cpp b/tests/YGStyleAccessorsTest.cpp index 2801536f..2e96af92 100644 --- a/tests/YGStyleAccessorsTest.cpp +++ b/tests/YGStyleAccessorsTest.cpp @@ -76,8 +76,7 @@ INDEX_ACCESSOR_TESTS(__VA_ARGS__)(NAME, IDX, __VA_ARGS__) \ } -namespace facebook { -namespace yoga { +namespace facebook::yoga { using CompactValue = detail::CompactValue; @@ -255,5 +254,4 @@ ACCESSOR_TEST( #endif -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga diff --git a/tests/util/TestUtil.cpp b/tests/util/TestUtil.cpp index ab7ff504..2ae34e0f 100644 --- a/tests/util/TestUtil.cpp +++ b/tests/util/TestUtil.cpp @@ -10,9 +10,7 @@ #include #include -namespace facebook { -namespace yoga { -namespace test { +namespace facebook::yoga::test { int nodeInstanceCount = 0; @@ -61,6 +59,4 @@ ScopedEventSubscription::~ScopedEventSubscription() { Event::reset(); } -} // namespace test -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::test diff --git a/tests/util/TestUtil.h b/tests/util/TestUtil.h index 5cc16e41..1fd3a921 100644 --- a/tests/util/TestUtil.h +++ b/tests/util/TestUtil.h @@ -11,9 +11,7 @@ #include -namespace facebook { -namespace yoga { -namespace test { +namespace facebook::yoga::test { struct YOGA_EXPORT TestUtil { static void startCountingNodes(); @@ -26,6 +24,4 @@ struct ScopedEventSubscription { ~ScopedEventSubscription(); }; -} // namespace test -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::test diff --git a/yoga/BitUtils.h b/yoga/BitUtils.h index e544defa..7c915505 100644 --- a/yoga/BitUtils.h +++ b/yoga/BitUtils.h @@ -13,10 +13,7 @@ #include -namespace facebook { -namespace yoga { - -namespace detail { +namespace facebook::yoga::detail { // std::bitset with one bit for each option defined in YG_ENUM_SEQ_DECL template @@ -68,6 +65,4 @@ inline void setBooleanData(uint8_t& flags, size_t index, bool value) { } } -} // namespace detail -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::detail diff --git a/yoga/CompactValue.h b/yoga/CompactValue.h index 20462ce3..9d494500 100644 --- a/yoga/CompactValue.h +++ b/yoga/CompactValue.h @@ -38,9 +38,7 @@ static_assert( #define VISIBLE_FOR_TESTING private: #endif -namespace facebook { -namespace yoga { -namespace detail { +namespace facebook::yoga::detail { // This class stores YGValue in 32 bits. // - The value does not matter for Undefined and Auto. NaNs are used for their @@ -209,6 +207,4 @@ constexpr bool operator!=(CompactValue a, CompactValue b) noexcept { return !(a == b); } -} // namespace detail -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::detail diff --git a/yoga/YGConfig.cpp b/yoga/YGConfig.cpp index 5bf85f4a..93c16c69 100644 --- a/yoga/YGConfig.cpp +++ b/yoga/YGConfig.cpp @@ -9,16 +9,14 @@ using namespace facebook::yoga; -namespace facebook { -namespace yoga { +namespace facebook::yoga { bool configUpdateInvalidatesLayout(YGConfigRef a, YGConfigRef b) { return a->getErrata() != b->getErrata() || a->getEnabledExperiments() != b->getEnabledExperiments() || a->getPointScaleFactor() != b->getPointScaleFactor() || a->useWebDefaults() != b->useWebDefaults(); } -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga YGConfig::YGConfig(YGLogger logger) : cloneNodeCallback_{nullptr} { setLogger(logger); diff --git a/yoga/YGConfig.h b/yoga/YGConfig.h index d7c7f49f..391e2500 100644 --- a/yoga/YGConfig.h +++ b/yoga/YGConfig.h @@ -12,8 +12,7 @@ #include "BitUtils.h" #include "Yoga-internal.h" -namespace facebook { -namespace yoga { +namespace facebook::yoga { // Whether moving a node from config "a" to config "b" should dirty previously // calculated layout results. @@ -48,8 +47,7 @@ struct YGConfigFlags { }; #pragma pack(pop) -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga struct YOGA_EXPORT YGConfig { YGConfig(YGLogger logger); diff --git a/yoga/YGMacros.h b/yoga/YGMacros.h index cd137117..18bf6d3f 100644 --- a/yoga/YGMacros.h +++ b/yoga/YGMacros.h @@ -95,9 +95,8 @@ #endif #ifdef __cplusplus -namespace facebook { -namespace yoga { -namespace enums { + +namespace facebook::yoga::enums { template constexpr int count(); // can't use `= delete` due to a defect in clang < 3.9 @@ -109,9 +108,7 @@ constexpr int n() { } } // namespace detail -} // namespace enums -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::enums #endif #define YG_ENUM_DECL(NAME, ...) \ @@ -122,16 +119,13 @@ constexpr int n() { #define YG_ENUM_SEQ_DECL(NAME, ...) \ YG_ENUM_DECL(NAME, __VA_ARGS__) \ YG_EXTERN_C_END \ - namespace facebook { \ - namespace yoga { \ - namespace enums { \ + \ + namespace facebook::yoga::enums { \ template <> \ constexpr int count() { \ return detail::n<__VA_ARGS__>(); \ } \ } \ - } \ - } \ YG_EXTERN_C_BEGIN #else #define YG_ENUM_SEQ_DECL YG_ENUM_DECL diff --git a/yoga/YGNodePrint.cpp b/yoga/YGNodePrint.cpp index d4d3499a..7aa50f07 100644 --- a/yoga/YGNodePrint.cpp +++ b/yoga/YGNodePrint.cpp @@ -16,8 +16,7 @@ #include "Yoga-internal.h" #include "Utils.h" -namespace facebook { -namespace yoga { +namespace facebook::yoga { typedef std::string string; static void indent(string& base, uint32_t level) { @@ -242,6 +241,6 @@ void YGNodeToString( } appendFormattedString(str, ""); } -} // namespace yoga -} // namespace facebook + +} // namespace facebook::yoga #endif diff --git a/yoga/YGNodePrint.h b/yoga/YGNodePrint.h index ac550e96..7648f83c 100644 --- a/yoga/YGNodePrint.h +++ b/yoga/YGNodePrint.h @@ -13,8 +13,7 @@ #include -namespace facebook { -namespace yoga { +namespace facebook::yoga { void YGNodeToString( std::string& str, @@ -22,7 +21,6 @@ void YGNodeToString( YGPrintOptions options, uint32_t level); -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga #endif diff --git a/yoga/Yoga-internal.h b/yoga/Yoga-internal.h index 5c5f11c7..c16c2ad5 100644 --- a/yoga/Yoga-internal.h +++ b/yoga/Yoga-internal.h @@ -33,8 +33,7 @@ void YGNodeDeallocate(YGNodeRef node); YG_EXTERN_C_END -namespace facebook { -namespace yoga { +namespace facebook::yoga { inline bool isUndefined(float value) { return std::isnan(value); @@ -46,8 +45,7 @@ inline bool isUndefined(double value) { void throwLogicalErrorWithMessage(const char* message); -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga extern const std::array trailing; extern const std::array leading; @@ -103,9 +101,7 @@ struct YGCachedMeasurement { // 98% of analyzed layouts require less than 8 entries. #define YG_MAX_CACHED_RESULT_COUNT 8 -namespace facebook { -namespace yoga { -namespace detail { +namespace facebook::yoga::detail { template class Values { @@ -149,9 +145,8 @@ public: Values& operator=(const Values& other) = default; }; -} // namespace detail -} // namespace yoga -} // namespace facebook + +} // namespace facebook::yoga::detail static const float kDefaultFlexGrow = 0.0f; static const float kDefaultFlexShrink = 0.0f; diff --git a/yoga/event/event.cpp b/yoga/event/event.cpp index 152c4e16..ee47331d 100644 --- a/yoga/event/event.cpp +++ b/yoga/event/event.cpp @@ -9,8 +9,7 @@ #include #include -namespace facebook { -namespace yoga { +namespace facebook::yoga { const char* LayoutPassReasonToString(const LayoutPassReason value) { switch (value) { @@ -82,5 +81,4 @@ void Event::publish(const YGNode& node, Type eventType, const Data& eventData) { } } -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga diff --git a/yoga/event/event.h b/yoga/event/event.h index c917467e..4c34fa66 100644 --- a/yoga/event/event.h +++ b/yoga/event/event.h @@ -16,8 +16,7 @@ struct YGConfig; struct YGNode; -namespace facebook { -namespace yoga { +namespace facebook::yoga { enum struct LayoutType : int { kLayout = 0, @@ -140,5 +139,4 @@ struct Event::TypedData { void* layoutContext; }; -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga diff --git a/yoga/log.cpp b/yoga/log.cpp index 6cdd3f69..51040592 100644 --- a/yoga/log.cpp +++ b/yoga/log.cpp @@ -11,9 +11,7 @@ #include "YGConfig.h" #include "YGNode.h" -namespace facebook { -namespace yoga { -namespace detail { +namespace facebook::yoga::detail { namespace { @@ -59,6 +57,4 @@ void Log::log( va_end(args); } -} // namespace detail -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::detail diff --git a/yoga/log.h b/yoga/log.h index 419724e2..070a164d 100644 --- a/yoga/log.h +++ b/yoga/log.h @@ -12,10 +12,7 @@ struct YGNode; struct YGConfig; -namespace facebook { -namespace yoga { - -namespace detail { +namespace facebook::yoga::detail { struct Log { static void log( @@ -33,6 +30,4 @@ struct Log { ...) noexcept; }; -} // namespace detail -} // namespace yoga -} // namespace facebook +} // namespace facebook::yoga::detail