Breaking: per-node pointScaleFactor (#1379)
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1379 X-link: https://github.com/facebook/react-native/pull/39403 Right now we have a `pointScaleFactor` per-node, but only ever read the one off the root node. In most cases where config is global, these will be the same, but it is possible for these to differ. This... doesn't make much sense from an API perspective, and there are edge cases where we may want to allow laying out a subtree with a different DPI then the rest of the tree (though I think there might be other solutions to that). We should rethink some of what is currently on config being allowed per-node (do we really need each node to be able to have a separate logger?), but this makes the model consistent in the meantime. This change is breaking to any users relying on setting `pointScaleFactor` on the config of the root node, but not other nodes. Reviewed By: yungsters Differential Revision: D49181131 fbshipit-source-id: f1363ca242094f04b995fd50c1e56834d5003425
This commit is contained in:
committed by
Facebook GitHub Bot
parent
0a90b16ac6
commit
66cc95f932
@@ -23,7 +23,6 @@ float roundValueToPixelGrid(
|
||||
// Round the layout results of a node and its subtree to the pixel grid.
|
||||
void roundLayoutResultsToPixelGrid(
|
||||
yoga::Node* const node,
|
||||
const double pointScaleFactor,
|
||||
const double absoluteLeft,
|
||||
const double absoluteTop);
|
||||
|
||||
|
Reference in New Issue
Block a user