DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

change default value of position styles

Browse Source 
Summary: Default value for positions should be undefined not 0px. Fixing this leads to more correct tests.

Reviewed By: gkassabli

Differential Revision: D4153329

fbshipit-source-id: d0f194f9c47eac93d3815ec7e55568a1016bc7fe
This commit is contained in:
Emil Sjolander
2016-11-09 09:10:54 -08:00
committed by Facebook Github Bot
parent e54af5e854
commit 6a6efe0764
5 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
csharp/tests/Facebook.CSSLayout/CSSLayoutAbsolutePositionTest.cs
View File

@@ -27,7 +27,7 @@
</div> </div>
<div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;"> <div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;">
<div style="position: absolute; start: 0; top: 0;"> <div style="position: absolute; start: 0px; top: 0px;">
<div style="width: 100px; height: 100px;"></div> <div style="width: 100px; height: 100px;"></div>
</div> </div>
</div> </div>
@@ -219,6 +219,8 @@ namespace Facebook.CSSLayout
CSSNode root_child0 = new CSSNode(); CSSNode root_child0 = new CSSNode();
root_child0.PositionType = CSSPositionType.Absolute; root_child0.PositionType = CSSPositionType.Absolute;
root_child0.SetPosition(CSSEdge.Start, 0);
root_child0.SetPosition(CSSEdge.Top, 0);
root.Insert(0, root_child0); root.Insert(0, root_child0);
CSSNode root_child0_child0 = new CSSNode(); CSSNode root_child0_child0 = new CSSNode();

2
gentest/fixtures/CSSLayoutAbsolutePositionTest.html
View File

@@ -15,7 +15,7 @@
</div> </div>
<div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;"> <div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;">
<div style="position: absolute; start: 0; top: 0;"> <div style="position: absolute; start: 0px; top: 0px;">
<div style="width: 100px; height: 100px;"></div> <div style="width: 100px; height: 100px;"></div>
</div> </div>
</div> </div>

17
gentest/gentest.js
View File

@@ -159,10 +159,10 @@ function checkDefaultValues() {
{style:'overflow', value:'visible'}, {style:'overflow', value:'visible'},
{style:'flex-grow', value:'0'}, {style:'flex-grow', value:'0'},
{style:'flex-shrink', value:'0'}, {style:'flex-shrink', value:'0'},
{style:'left', value:'0px'}, {style:'left', value:'undefined'},
{style:'top', value:'0px'}, {style:'top', value:'undefined'},
{style:'right', value:'0px'}, {style:'right', value:'undefined'},
{style:'bottom', value:'0px'}, {style:'bottom', value:'undefined'},
].forEach(function(item) { ].forEach(function(item) {
assert(item.value === getDefaultStyleValue(item.style), assert(item.value === getDefaultStyleValue(item.style),
item.style + ' should be ' + item.value); item.style + ' should be ' + item.value);
@@ -415,6 +415,15 @@ function getDefaultStyleValue(style) {
if (style == 'position') { if (style == 'position') {
return 'relative'; return 'relative';
} }
switch (style) {
case 'left':
case 'top':
case 'right':
case 'bottom':
case 'start':
case 'end':
return 'undefined';
}
var node = document.getElementById('default'); var node = document.getElementById('default');
return getComputedStyle(node, null).getPropertyValue(style); return getComputedStyle(node, null).getPropertyValue(style);
} }

4
java/tests/com/facebook/csslayout/CSSLayoutAbsolutePositionTest.java
View File

@@ -27,7 +27,7 @@
</div> </div>
<div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;"> <div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;">
<div style="position: absolute; start: 0; top: 0;"> <div style="position: absolute; start: 0px; top: 0px;">
<div style="width: 100px; height: 100px;"></div> <div style="width: 100px; height: 100px;"></div>
</div> </div>
</div> </div>
@@ -213,6 +213,8 @@ public class CSSLayoutAbsolutePositionTest {
final CSSNode root_child0 = new CSSNode(); final CSSNode root_child0 = new CSSNode();
root_child0.setPositionType(CSSPositionType.ABSOLUTE); root_child0.setPositionType(CSSPositionType.ABSOLUTE);
root_child0.setPosition(Spacing.START, 0);
root_child0.setPosition(Spacing.TOP, 0);
root.addChildAt(root_child0, 0); root.addChildAt(root_child0, 0);
final CSSNode root_child0_child0 = new CSSNode(); final CSSNode root_child0_child0 = new CSSNode();

4
tests/CSSLayoutAbsolutePositionTest.cpp
View File

@@ -27,7 +27,7 @@
</div> </div>
<div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;"> <div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;">
<div style="position: absolute; start: 0; top: 0;"> <div style="position: absolute; start: 0px; top: 0px;">
<div style="width: 100px; height: 100px;"></div> <div style="width: 100px; height: 100px;"></div>
</div> </div>
</div> </div>
@@ -204,6 +204,8 @@ TEST(CSSLayoutTest, do_not_clamp_height_of_absolute_node_to_height_of_its_overfl
const CSSNodeRef root_child0 = CSSNodeNew(); const CSSNodeRef root_child0 = CSSNodeNew();
CSSNodeStyleSetPositionType(root_child0, CSSPositionTypeAbsolute); CSSNodeStyleSetPositionType(root_child0, CSSPositionTypeAbsolute);
CSSNodeStyleSetPosition(root_child0, CSSEdgeStart, 0);
CSSNodeStyleSetPosition(root_child0, CSSEdgeTop, 0);
CSSNodeInsertChild(root, root_child0, 0); CSSNodeInsertChild(root, root_child0, 0);
const CSSNodeRef root_child0_child0 = CSSNodeNew(); const CSSNodeRef root_child0_child0 = CSSNodeNew();