DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix flex-end/flex-start RTL transpilation

Browse Source 
Summary: Oops, when regexing start->left/right end->left/right I did not take into account flex-start and flex-end. Easiest solution is to regex back flex-left and flex-right into their correct values.

Reviewed By: lucasr

Differential Revision: D3930244

fbshipit-source-id: 20742cbc8e5f23af694e14584c7c3df89526876e
This commit is contained in:
Emil Sjolander
2016-09-27 08:46:07 -07:00
committed by Facebook Github Bot 4
parent 9c93c7fc42
commit 6b16dc4060
7 changed files with 52 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
gentest/gentest.js
View File

@@ -69,7 +69,12 @@ function printTest(LTRContainer, RTLContainer, genericContainer) {
for (var i = 0; i < genericLayoutTree.length; i++) {
lines.push('TEST(CSSLayoutTest, ' + genericLayoutTree[i].name + ') {');
lines.push(' ' + setupTestTree(LTRLayoutTree[i], genericLayoutTree[i], 'root', null).reduce(function(curr, prev) {
lines.push(' ' + setupTestTree(
undefined,
LTRLayoutTree[i],
genericLayoutTree[i],
'root',
null).reduce(function(curr, prev) {
return curr + '\n ' + prev;
}));
@@ -112,7 +117,7 @@ function assertTestTree(node, nodeName, parentName) {
return lines;
}
function setupTestTree(node, genericNode, nodeName, parentName, index) {
function setupTestTree(parent, node, genericNode, nodeName, parentName, index) {
var lines = [
'const CSSNodeRef ' + nodeName + ' = CSSNodeNew();',
];
@@ -154,15 +159,18 @@ function setupTestTree(node, genericNode, nodeName, parentName, index) {
alignValue(node.style[style]) + ');');
break;
case 'align-self':
lines.push('CSSNodeStyleSetAlignSelf(' + nodeName + ', ' +
alignValue(node.style[style]) + ');');
if (!parent || node.style[style] !== parent.style['align-items']) {
lines.push('CSSNodeStyleSetAlignSelf(' + nodeName + ', ' +
alignValue(node.style[style]) + ');');
}
break;
case 'position':
lines.push('CSSNodeStyleSetPositionType(' + nodeName + ', ' +
positionValue(node.style[style]) + ');');
break;
case 'flex-wrap':
lines.push('CSSNodeStyleSetFlexWrap(' + nodeName + ', ' + wrapValue(node.style[style]) + ');');
lines.push('CSSNodeStyleSetFlexWrap(' + nodeName + ', ' +
wrapValue(node.style[style]) + ');');
break;
case 'overflow':
lines.push('CSSNodeStyleSetOverflow(' + nodeName + ', ' +
@@ -319,6 +327,7 @@ function setupTestTree(node, genericNode, nodeName, parentName, index) {
var childName = nodeName + '_child' + i;
lines = lines.concat(
setupTestTree(
node,
node.children[i],
genericNode.children[i],
childName,