DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Store YGFloatOptional in 32 bits

Browse Source 
Summary:
@public

After removing `-ffast-math`, `NaN` can again be used to represent `undefined`. That allows us to remove the additional flag from `YGFloatOptional`, and reduce memory usage.

Reviewed By: SidharthGuglani

Differential Revision: D13439611

fbshipit-source-id: 93e90f72f0415edb228b4e7d145e1fae35cc6b43
This commit is contained in:
David Aurelio
2018-12-13 07:09:30 -08:00
committed by Facebook Github Bot
parent da678ef971
commit 6bdd39d0ed
4 changed files with 34 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/YGFloatOptionalTest.cpp
View File

@@ -10,11 +10,11 @@
#include <yoga/YGFloatOptional.h>
#include <yoga/YGValue.h>
static const auto empty = YGFloatOptional{};
static const auto zero = YGFloatOptional{0.0f};
static const auto one = YGFloatOptional{1.0f};
static const auto positive = YGFloatOptional{1234.5f};
static const auto negative = YGFloatOptional{-9876.5f};
constexpr auto empty = YGFloatOptional{};
constexpr auto zero = YGFloatOptional{0.0f};
constexpr auto one = YGFloatOptional{1.0f};
constexpr auto positive = YGFloatOptional{1234.5f};
constexpr auto negative = YGFloatOptional{-9876.5f};
TEST(YGFloatOptional, value) {
ASSERT_EQ(zero.getValue(), 0.0f);