Adds Javascript Support
Summary: - As mentioned in the title, this PR adds Javascript support to Yoga. Two different builds are included in this PR thanks to [nbind](https://github.com/charto/nbind), which conveniently allow to target both Node.js' native addons and browser environments via asmjs with approximately the same codebase. That should solve #215. - All tests successfully pass on both codepaths. You can run `yarn test:all` inside the `javascript` directory to test it. - Because of a bug in nbind, the [following PR](https://github.com/charto/nbind/pull/57) needs to be merged and a new version released before this one can be safely merged as well. - I had to use `double` types instead of `float` in the C++ bindings because of an Emscripten [bug](https://github.com/kripken/emscripten/issues/3592) where symbols aren't correctly exported when using floats. - There's some tweaks to do before this PR is 100% ready to merge, but I wanted to have your opinion first. What do you think of this? --- To do: - [x] Ensure th Closes https://github.com/facebook/yoga/pull/304 Reviewed By: mikearmstrong001 Differential Revision: D4375187 Pulled By: emilsjolander fbshipit-source-id: 47248558a9506b7c512b5ef281cd12fe1a60cab7
This commit is contained in:
committed by
Facebook Github Bot
parent
352f592767
commit
6f462a72bf
36
javascript/sources/Size.hh
Normal file
36
javascript/sources/Size.hh
Normal file
@@ -0,0 +1,36 @@
|
||||
/**
|
||||
* Copyright (c) 2014-present, Facebook, Inc.
|
||||
* All rights reserved.
|
||||
*
|
||||
* This source code is licensed under the BSD-style license found in the
|
||||
* LICENSE file in the root directory of this source tree. An additional grant
|
||||
* of patent rights can be found in the PATENTS file in the same directory.
|
||||
*/
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <nbind/api.h>
|
||||
#include <nbind/BindDefiner.h>
|
||||
|
||||
struct Size
|
||||
{
|
||||
double width;
|
||||
double height;
|
||||
|
||||
Size(void)
|
||||
: width(0.0)
|
||||
, height(0.0)
|
||||
{
|
||||
}
|
||||
|
||||
Size(double width, double height)
|
||||
: width(width)
|
||||
, height(height)
|
||||
{
|
||||
}
|
||||
|
||||
void toJS(nbind::cbOutput expose) const
|
||||
{
|
||||
expose(width, height);
|
||||
}
|
||||
};
|
Reference in New Issue
Block a user