DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Adds Javascript Support

Browse Source 
Summary:
- As mentioned in the title, this PR adds Javascript support to Yoga. Two different builds are included in this PR thanks to [nbind](https://github.com/charto/nbind), which conveniently allow to target both Node.js' native addons and browser environments via asmjs with approximately the same codebase. That should solve #215.

- All tests successfully pass on both codepaths. You can run `yarn test:all` inside the `javascript` directory to test it.

- Because of a bug in nbind, the [following PR](https://github.com/charto/nbind/pull/57) needs to be merged and a new version released before this one can be safely merged as well.

- I had to use `double` types instead of `float` in the C++ bindings because of an Emscripten [bug](https://github.com/kripken/emscripten/issues/3592) where symbols aren't correctly exported when using floats.

- There's some tweaks to do before this PR is 100% ready to merge, but I wanted to have your opinion first. What do you think of this?

 ---

To do:

- [x] Ensure th
Closes https://github.com/facebook/yoga/pull/304

Reviewed By: mikearmstrong001

Differential Revision: D4375187

Pulled By: emilsjolander

fbshipit-source-id: 47248558a9506b7c512b5ef281cd12fe1a60cab7
This commit is contained in:
Maël Nison
2017-01-02 02:22:45 -08:00
committed by Facebook Github Bot
parent 352f592767
commit 6f462a72bf
45 changed files with 9272 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
javascript/tests/index.html Normal file
View File

@@ -0,0 +1,34 @@
<html>
<script>
function it(name, func) {
console.log(name);
func();
}
function YGBENCHMARK(name, func) {
console.log(name);
func();
}
</script>
<script src="../dist/Yoga.bundle.js"></script>
<script src="./tools.js"></script>
<script src="./Facebook.Yoga/YGAbsolutePositionTest.js"></script>
<script src="./Facebook.Yoga/YGAlignContentTest.js"></script>
<script src="./Facebook.Yoga/YGAlignItemsTest.js"></script>
<script src="./Facebook.Yoga/YGAlignSelfTest.js"></script>
<script src="./Facebook.Yoga/YGBorderTest.js"></script>
<script src="./Facebook.Yoga/YGFlexDirectionTest.js"></script>
<script src="./Facebook.Yoga/YGFlexTest.js"></script>
<script src="./Facebook.Yoga/YGFlexWrapTest.js"></script>
<script src="./Facebook.Yoga/YGJustifyContentTest.js"></script>
<script src="./Facebook.Yoga/YGMarginTest.js"></script>
<script src="./Facebook.Yoga/YGMinMaxDimensionTest.js"></script>
<script src="./Facebook.Yoga/YGPaddingTest.js"></script>
<script src="./Facebook.Yoga/YGRoundingTest.js"></script>
<script src="./Benchmarks/YGBenchmark.js"></script>
</html>