Rename uikit/CSSLayout to CSSLayoutKit.
Summary: When trying to integrate this into an Xcode project that already included CSSLayout.[c|h], we were getting a linker error. Upon digging in, I found out that Xcode was becoming confused because the imports of the uikit library and the c library are both `#import <CSSLayout/CSSLayout.h>`. So, it needed a new name. Reviewed By: emilsjolander Differential Revision: D4162621 fbshipit-source-id: b5f7624eb29f1b9eaebbed5104ec9ea8a12ad2e5
This commit is contained in:
committed by
Facebook Github Bot
parent
3e2c13f418
commit
70e01a4476
@@ -19,7 +19,7 @@ before_install:
|
|||||||
script:
|
script:
|
||||||
- buck test //:CSSLayout
|
- buck test //:CSSLayout
|
||||||
- buck test //java:java
|
- buck test //java:java
|
||||||
- buck test //uikit/CSSLayout:CSSLayout --config cxx.default_platform=iphonesimulator-x86_64
|
- buck test //CSSLayoutKit:CSSLayoutKit --config cxx.default_platform=iphonesimulator-x86_64
|
||||||
- buck run //benchmark:benchmark
|
- buck run //benchmark:benchmark
|
||||||
- git checkout HEAD^
|
- git checkout HEAD^
|
||||||
- buck run //benchmark:benchmark
|
- buck run //benchmark:benchmark
|
||||||
|
@@ -10,9 +10,9 @@ include_defs('//CSSLAYOUT_DEFS')
|
|||||||
UIKIT_CSSLAYOUT_COMPILER_FLAGS = ['-fobjc-arc']
|
UIKIT_CSSLAYOUT_COMPILER_FLAGS = ['-fobjc-arc']
|
||||||
|
|
||||||
apple_library(
|
apple_library(
|
||||||
name = 'CSSLayout',
|
name = 'CSSLayoutKit',
|
||||||
compiler_flags = UIKIT_CSSLAYOUT_COMPILER_FLAGS,
|
compiler_flags = UIKIT_CSSLAYOUT_COMPILER_FLAGS,
|
||||||
tests = [':CSSLayoutTests'],
|
tests = [':CSSLayoutKitTests'],
|
||||||
srcs = glob(['*.m']),
|
srcs = glob(['*.m']),
|
||||||
exported_headers = glob(['*.h']),
|
exported_headers = glob(['*.h']),
|
||||||
frameworks = [
|
frameworks = [
|
||||||
@@ -26,7 +26,7 @@ apple_library(
|
|||||||
)
|
)
|
||||||
|
|
||||||
apple_test(
|
apple_test(
|
||||||
name = 'CSSLayoutTests',
|
name = 'CSSLayoutKitTests',
|
||||||
compiler_flags = UIKIT_CSSLAYOUT_COMPILER_FLAGS,
|
compiler_flags = UIKIT_CSSLAYOUT_COMPILER_FLAGS,
|
||||||
info_plist = 'Tests/Info.plist',
|
info_plist = 'Tests/Info.plist',
|
||||||
srcs = glob(['Tests/**/*.m']),
|
srcs = glob(['Tests/**/*.m']),
|
||||||
@@ -35,7 +35,7 @@ apple_test(
|
|||||||
'$PLATFORM_DIR/Developer/Library/Frameworks/XCTest.framework',
|
'$PLATFORM_DIR/Developer/Library/Frameworks/XCTest.framework',
|
||||||
],
|
],
|
||||||
deps = [
|
deps = [
|
||||||
':CSSLayout',
|
':CSSLayoutKit',
|
||||||
],
|
],
|
||||||
visibility = ['PUBLIC'],
|
visibility = ['PUBLIC'],
|
||||||
)
|
)
|
@@ -91,7 +91,7 @@ root.getLayoutHeight();
|
|||||||
```
|
```
|
||||||
|
|
||||||
### UIKit
|
### UIKit
|
||||||
The full API can be found in `uikit/CSSLayout/UIView+CSSLayout.h`.
|
The full API can be found in `CSSLayoutKit/UIView+CSSLayout.h`.
|
||||||
|
|
||||||
```objective-c
|
```objective-c
|
||||||
UIView *root = [UIView new];
|
UIView *root = [UIView new];
|
||||||
|
Reference in New Issue
Block a user