DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Improve JS bindings

Browse Source 
Summary:
- Fix a few things related to how npm should publish the package (sources were in the gitignore file, so I think it would have break the build during install - I fixed this by adding a npmignore that should override the gitignore rules)

- The enumerations values are now generated directly from `enums.py`

- I added percent unit support (#258) to the bindings (`.setWidthPercent` is currently exposed, but I've also added a very very little parsing to also support `.setWidth("100%")` and `.setWidth(.getWidth())`), added the missing tests, and fixed Travis.
Closes https://github.com/facebook/yoga/pull/314

Reviewed By: mikearmstrong001

Differential Revision: D4377198

Pulled By: emilsjolander

fbshipit-source-id: 774dfafd416f5421f3be59a1d181eb7056487abe
This commit is contained in:
Maël Nison
2017-01-04 04:33:39 -08:00
committed by Facebook Github Bot
parent 663a93912b
commit 7108454455
12 changed files with 1344 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
javascript/sources/Node.hh
View File

@@ -17,6 +17,7 @@
#include "./Layout.hh"
#include "./Size.hh"
#include "./Value.hh"
class Node {
@@ -53,6 +54,7 @@ class Node {
void setPositionType(int positionType);
void setPosition(int edge, double position);
void setPositionPercent(int edge, double position);
void setAlignContent(int alignContent);
void setAlignItems(int alignItems);
@@ -62,33 +64,42 @@ class Node {
void setJustifyContent(int justifyContent);
void setMargin(int edge, double margin);
void setMarginPercent(int edge, double margin);
void setOverflow(int overflow);
void setFlex(double flex);
void setFlexBasis(double flexBasis);
void setFlexBasisPercent(double flexBasis);
void setFlexGrow(double flexGrow);
void setFlexShrink(double flexShrink);
void setWidth(double width);
void setWidthPercent(double width);
void setHeight(double height);
void setHeightPercent(double height);
void setMinWidth(double minWidth);
void setMinWidthPercent(double minWidth);
void setMinHeight(double minHeight);
void setMinHeightPercent(double minHeight);
void setMaxWidth(double maxWidth);
void setMaxWidthPercent(double maxWidth);
void setMaxHeight(double maxHeight);
void setMaxHeightPercent(double maxHeight);
void setAspectRatio(double aspectRatio);
void setBorder(int edge, double border);
void setPadding(int edge, double padding);
void setPaddingPercent(int edge, double padding);
public: // Style getters
int getPositionType(void) const;
double getPosition(int edge) const;
Value getPosition(int edge) const;
int getAlignContent(void) const;
int getAlignItems(void) const;
@@ -97,28 +108,28 @@ class Node {
int getFlexWrap(void) const;
int getJustifyContent(void) const;
double getMargin(int edge) const;
Value getMargin(int edge) const;
int getOverflow(void) const;
double getFlexBasis(void) const;
Value getFlexBasis(void) const;
double getFlexGrow(void) const;
double getFlexShrink(void) const;
double getWidth(void) const;
double getHeight(void) const;
Value getWidth(void) const;
Value getHeight(void) const;
double getMinWidth(void) const;
double getMinHeight(void) const;
Value getMinWidth(void) const;
Value getMinHeight(void) const;
double getMaxWidth(void) const;
double getMaxHeight(void) const;
Value getMaxWidth(void) const;
Value getMaxHeight(void) const;
double getAspectRatio(void) const;
double getBorder(int edge) const;
double getPadding(int edge) const;
Value getPadding(int edge) const;
public: // Tree hierarchy mutators