DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Align C# implementation with Java

Browse Source 
Summary:
- Align C# implementation with Java JNI implementation
  - No need to call init(reinit)
  - Rename Initialize and Reset
- Add unittests

Reviewed By: emilsjolander

Differential Revision: D4009351

fbshipit-source-id: 191ddec30b0c8518eb0d76c0579afe909b673fac
This commit is contained in:
Kazuki Sakamoto
2016-10-13 07:52:44 -07:00
committed by Facebook Github Bot
parent 2a8a4e10c6
commit 722bfb9032
3 changed files with 108 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
csharp/Facebook.CSSLayout/CSSNode.cs
View File

@@ -30,6 +30,7 @@ namespace Facebook.CSSLayout
{
_measureFunc = MeasureInternal;
_printFunc = PrintInternal;
Reinitialize();
}
private void AssertNativeInstance()
@@ -72,8 +73,27 @@ namespace Facebook.CSSLayout
private void FreeManaged()
{
_children = null;
_parent = null;
if (_children != null)
{
for (int i = 0; i < _children.Count; ++i)
{
var child = _children[i];
child.AssertNativeInstance();
child._parent = null;
Native.CSSNodeRemoveChild(_cssNode, child._cssNode);
}
_children = null;
}
if (_parent != null)
{
var parent = _parent.Target as CSSNode;
parent.AssertNativeInstance();
parent._children.Remove(this);
Native.CSSNodeRemoveChild(parent._cssNode, _cssNode);
_parent = null;
}
_measureFunction = null;
}
@@ -86,7 +106,7 @@ namespace Facebook.CSSLayout
}
}
public void Initialize()
public void Reinitialize()
{
if (_cssNode != IntPtr.Zero)
{
@@ -99,9 +119,13 @@ namespace Facebook.CSSLayout
Native.CSSNodeSetPrintFunc(_cssNode, _printFunc);
}
public void Reset()
public void Free()
{
AssertNativeInstance();
if (_parent != null || (_children != null && _children.Count > 0))
{
throw new InvalidOperationException("You should not free an attached CSSNode");
}
FreeManaged();
FreeUnmanaged();
}