From 79281049f20de8902b9e25f23d1ee5606199112a Mon Sep 17 00:00:00 2001 From: Jonathan Dann Date: Wed, 21 Mar 2018 16:05:12 -0700 Subject: [PATCH] Mark more member functions as const Summary: These don't mutate internal state. Reviewed By: priteshrnandgaonkar Differential Revision: D7291364 fbshipit-source-id: 2e7d96cfe0345692ffa411bb21a80eb7a859880b --- yoga/YGNode.cpp | 26 +++++++++++++------------- yoga/YGNode.h | 26 +++++++++++++------------- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/yoga/YGNode.cpp b/yoga/YGNode.cpp index 37b63042..8fcb44c3 100644 --- a/yoga/YGNode.cpp +++ b/yoga/YGNode.cpp @@ -87,7 +87,7 @@ std::array YGNode::getResolvedDimensions() const { float YGNode::getLeadingPosition( const YGFlexDirection axis, - const float axisSize) { + const float axisSize) const { if (YGFlexDirectionIsRow(axis)) { const YGValue* leadingPosition = YGComputedEdgeValue(style_.position, YGEdgeStart, &YGValueUndefined); @@ -106,7 +106,7 @@ float YGNode::getLeadingPosition( float YGNode::getTrailingPosition( const YGFlexDirection axis, - const float axisSize) { + const float axisSize) const { if (YGFlexDirectionIsRow(axis)) { const YGValue* trailingPosition = YGComputedEdgeValue(style_.position, YGEdgeEnd, &YGValueUndefined); @@ -123,7 +123,7 @@ float YGNode::getTrailingPosition( : YGUnwrapFloatOptional(YGResolveValue(*trailingPosition, axisSize)); } -bool YGNode::isLeadingPositionDefined(const YGFlexDirection axis) { +bool YGNode::isLeadingPositionDefined(const YGFlexDirection axis) const { return (YGFlexDirectionIsRow(axis) && YGComputedEdgeValue(style_.position, YGEdgeStart, &YGValueUndefined) ->unit != YGUnitUndefined) || @@ -131,7 +131,7 @@ bool YGNode::isLeadingPositionDefined(const YGFlexDirection axis) { ->unit != YGUnitUndefined; } -bool YGNode::isTrailingPosDefined(const YGFlexDirection axis) { +bool YGNode::isTrailingPosDefined(const YGFlexDirection axis) const { return (YGFlexDirectionIsRow(axis) && YGComputedEdgeValue(style_.position, YGEdgeEnd, &YGValueUndefined) ->unit != YGUnitUndefined) || @@ -141,7 +141,7 @@ bool YGNode::isTrailingPosDefined(const YGFlexDirection axis) { float YGNode::getLeadingMargin( const YGFlexDirection axis, - const float widthSize) { + const float widthSize) const { if (YGFlexDirectionIsRow(axis) && style_.margin[YGEdgeStart].unit != YGUnitUndefined) { return YGResolveValueMargin(style_.margin[YGEdgeStart], widthSize); @@ -154,7 +154,7 @@ float YGNode::getLeadingMargin( float YGNode::getTrailingMargin( const YGFlexDirection axis, - const float widthSize) { + const float widthSize) const { if (YGFlexDirectionIsRow(axis) && style_.margin[YGEdgeEnd].unit != YGUnitUndefined) { return YGResolveValueMargin(style_.margin[YGEdgeEnd], widthSize); @@ -167,7 +167,7 @@ float YGNode::getTrailingMargin( float YGNode::getMarginForAxis( const YGFlexDirection axis, - const float widthSize) { + const float widthSize) const { return getLeadingMargin(axis, widthSize) + getTrailingMargin(axis, widthSize); } @@ -621,7 +621,7 @@ bool YGNode::isNodeFlexible() { (resolveFlexGrow() != 0 || resolveFlexShrink() != 0)); } -float YGNode::getLeadingBorder(const YGFlexDirection axis) { +float YGNode::getLeadingBorder(const YGFlexDirection axis) const { if (YGFlexDirectionIsRow(axis) && style_.border[YGEdgeStart].unit != YGUnitUndefined && !YGFloatIsUndefined(style_.border[YGEdgeStart].value) && @@ -634,7 +634,7 @@ float YGNode::getLeadingBorder(const YGFlexDirection axis) { return YGFloatMax(computedEdgeValue, 0.0f); } -float YGNode::getTrailingBorder(const YGFlexDirection flexDirection) { +float YGNode::getTrailingBorder(const YGFlexDirection flexDirection) const { if (YGFlexDirectionIsRow(flexDirection) && style_.border[YGEdgeEnd].unit != YGUnitUndefined && !YGFloatIsUndefined(style_.border[YGEdgeEnd].value) && @@ -650,7 +650,7 @@ float YGNode::getTrailingBorder(const YGFlexDirection flexDirection) { float YGNode::getLeadingPadding( const YGFlexDirection axis, - const float widthSize) { + const float widthSize) const { if (YGFlexDirectionIsRow(axis) && style_.padding[YGEdgeStart].unit != YGUnitUndefined && !YGResolveValue(style_.padding[YGEdgeStart], widthSize).isUndefined() && @@ -667,7 +667,7 @@ float YGNode::getLeadingPadding( float YGNode::getTrailingPadding( const YGFlexDirection axis, - const float widthSize) { + const float widthSize) const { if (YGFlexDirectionIsRow(axis) && style_.padding[YGEdgeEnd].unit != YGUnitUndefined && !YGResolveValue(style_.padding[YGEdgeEnd], widthSize).isUndefined() && @@ -685,13 +685,13 @@ float YGNode::getTrailingPadding( float YGNode::getLeadingPaddingAndBorder( const YGFlexDirection axis, - const float widthSize) { + const float widthSize) const { return getLeadingPadding(axis, widthSize) + getLeadingBorder(axis); } float YGNode::getTrailingPaddingAndBorder( const YGFlexDirection axis, - const float widthSize) { + const float widthSize) const { return getTrailingPadding(axis, widthSize) + getTrailingBorder(axis); } diff --git a/yoga/YGNode.h b/yoga/YGNode.h index c9c5599c..0ed05d7e 100644 --- a/yoga/YGNode.h +++ b/yoga/YGNode.h @@ -80,23 +80,23 @@ struct YGNode { YGValue getResolvedDimension(int index); // Methods related to positions, margin, padding and border - float getLeadingPosition(const YGFlexDirection axis, const float axisSize); - bool isLeadingPositionDefined(const YGFlexDirection axis); - bool isTrailingPosDefined(const YGFlexDirection axis); - float getTrailingPosition(const YGFlexDirection axis, const float axisSize); - float getLeadingMargin(const YGFlexDirection axis, const float widthSize); - float getTrailingMargin(const YGFlexDirection axis, const float widthSize); - float getLeadingBorder(const YGFlexDirection flexDirection); - float getTrailingBorder(const YGFlexDirection flexDirection); - float getLeadingPadding(const YGFlexDirection axis, const float widthSize); - float getTrailingPadding(const YGFlexDirection axis, const float widthSize); + float getLeadingPosition(const YGFlexDirection axis, const float axisSize) const; + bool isLeadingPositionDefined(const YGFlexDirection axis) const; + bool isTrailingPosDefined(const YGFlexDirection axis) const; + float getTrailingPosition(const YGFlexDirection axis, const float axisSize) const; + float getLeadingMargin(const YGFlexDirection axis, const float widthSize) const; + float getTrailingMargin(const YGFlexDirection axis, const float widthSize) const; + float getLeadingBorder(const YGFlexDirection flexDirection) const; + float getTrailingBorder(const YGFlexDirection flexDirection) const; + float getLeadingPadding(const YGFlexDirection axis, const float widthSize) const; + float getTrailingPadding(const YGFlexDirection axis, const float widthSize) const; float getLeadingPaddingAndBorder( const YGFlexDirection axis, - const float widthSize); + const float widthSize) const; float getTrailingPaddingAndBorder( const YGFlexDirection axis, - const float widthSize); - float getMarginForAxis(const YGFlexDirection axis, const float widthSize); + const float widthSize) const; + float getMarginForAxis(const YGFlexDirection axis, const float widthSize) const; // Setters void setContext(void* context);