DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Removed pinned CMake version from Gradle build (#1292)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1292

AGP 8.0 will now bring in a new enough CMake version to avoid internal warnings without extra configuration.

Differential Revision: D45766980

fbshipit-source-id: 9a5be41ec94d367b8486a3f808add938c798aee8
This commit is contained in:
Nick Gerleman
2023-05-11 02:14:41 -07:00
committed by Facebook GitHub Bot
parent 3b088c3383
commit 792ff666e5
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
build.gradle
View File

@@ -28,8 +28,7 @@ allprojects {
ext { ext {
buildToolsVersion = "33.0.0" buildToolsVersion = "33.0.0"
ndkVersion = "23.1.7779620" // Corresponds to AGP 7.3 ndkVersion = "23.1.7779620"
cmakeVersion = "3.18.1+"
minSdkVersion = 21 minSdkVersion = 21
compileSdkVersion = 33 compileSdkVersion = 33
targetSdkVersion = 33 targetSdkVersion = 33

1
java/build.gradle
View File

@@ -28,7 +28,6 @@ android {
externalNativeBuild { externalNativeBuild {
cmake { cmake {
version rootProject.cmakeVersion
path 'CMakeLists.txt' path 'CMakeLists.txt'
} }
} }