move YGMarkerMeasure and YGMarkerBaselineFn to event based system

Summary: Using yoga event listener for adding systrace sections for measure and baseline events

Reviewed By: davidaurelio

Differential Revision: D16048795

fbshipit-source-id: 3c2161328250184929ed1a3357b8c42ec8ca2e29
This commit is contained in:
Sidharth Guglani
2019-07-17 08:08:01 -07:00
committed by Facebook Github Bot
parent 6d916ab063
commit 7c891db9af
3 changed files with 4 additions and 57 deletions

View File

@@ -67,35 +67,6 @@ struct MarkerTest : public ::testing::Test {
uniquePtr<YGConfig> config;
};
TEST_F(MarkerTest, measure_functions_get_wrapped) {
auto root = makeNode();
YGNodeSetMeasureFunc(
root.get(), [](YGNodeRef, float, YGMeasureMode, float, YGMeasureMode) {
return YGSize{};
});
calculateLayout(root);
auto& markerCookie = findLastMarker(YGMarkerMeasure);
ASSERT_EQ(markerCookie.start.marker, YGMarkerMeasure)
<< "have " << markerCookies.size() << " recorded markers";
}
TEST_F(MarkerTest, baseline_functions_get_wrapped) {
auto root = makeNode();
auto child = addChild(root);
YGNodeSetBaselineFunc(
child.get(), [](YGNodeRef, float, float) { return 0.0f; });
YGNodeStyleSetFlexDirection(root.get(), YGFlexDirectionRow);
YGNodeStyleSetAlignItems(root.get(), YGAlignBaseline);
calculateLayout(root);
auto& markerCookie = findLastMarker(YGMarkerBaselineFn);
ASSERT_EQ(markerCookie.start.marker, YGMarkerBaselineFn)
<< "have " << markerCookies.size() << " recorded markers";
}
void* MarkerTest::startMarker(
YGMarker marker,
YGNodeRef node,
@@ -113,11 +84,6 @@ void MarkerTest::endMarker(
void* id) {
auto cookie = static_cast<MarkerCookie*>(id);
cookie->end = {{marker, node, data}, id, {}};
switch (marker) {
case YGMarkerMeasure:
case YGMarkerBaselineFn:
break;
};
}
uniquePtr<YGNode> MarkerTest::makeNode() {
@@ -141,12 +107,6 @@ void MarkerTest::calculateLayout(
namespace {
const char* markerTypeName(YGMarker type) {
switch (type) {
case YGMarkerMeasure:
return "YGMarkerMeasure";
case YGMarkerBaselineFn:
return "YGMarkerBaselineFn";
}
return "";
}