DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove skips on passing position tests and add errata tests

Browse Source 
Summary: Now that the tests are passing let's not skip it anymore. Also adding errata tests to make sure most prod builds are still protected.

Reviewed By: NickGerleman

Differential Revision: D50390993

fbshipit-source-id: cb91a7a377e919eaca24fb25e3d73d3c92eb8931
This commit is contained in:
Joe Vilches
2023-10-18 17:30:18 -07:00
committed by Facebook GitHub Bot
parent b6f85a1c76
commit 7e91004b90
5 changed files with 352 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/tests/com/facebook/yoga/YGFlexDirectionTest.java
View File

@@ -1672,7 +1672,6 @@ public class YGFlexDirectionTest {
}
@Test
@Ignore
public void test_flex_direction_row_reverse_pos_left() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -1841,7 +1840,6 @@ public class YGFlexDirectionTest {
}
@Test
@Ignore
public void test_flex_direction_row_reverse_pos_right() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -2010,7 +2008,6 @@ public class YGFlexDirectionTest {
}
@Test
@Ignore
public void test_flex_direction_column_reverse_pos_top() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -2095,7 +2092,6 @@ public class YGFlexDirectionTest {
}
@Test
@Ignore
public void test_flex_direction_column_reverse_pos_bottom() {
YogaConfig config = YogaConfigFactory.create();
config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);