Remove skips on passing position tests and add errata tests
Summary: Now that the tests are passing let's not skip it anymore. Also adding errata tests to make sure most prod builds are still protected. Reviewed By: NickGerleman Differential Revision: D50390993 fbshipit-source-id: cb91a7a377e919eaca24fb25e3d73d3c92eb8931
This commit is contained in:
committed by
Facebook GitHub Bot
parent
b6f85a1c76
commit
7e91004b90
@@ -1682,8 +1682,6 @@ TEST(YogaTest, flex_direction_column_reverse_border_bottom) {
|
||||
}
|
||||
|
||||
TEST(YogaTest, flex_direction_row_reverse_pos_left) {
|
||||
GTEST_SKIP();
|
||||
|
||||
const YGConfigRef config = YGConfigNew();
|
||||
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
|
||||
|
||||
@@ -1854,8 +1852,6 @@ TEST(YogaTest, flex_direction_row_reverse_pos_start) {
|
||||
}
|
||||
|
||||
TEST(YogaTest, flex_direction_row_reverse_pos_right) {
|
||||
GTEST_SKIP();
|
||||
|
||||
const YGConfigRef config = YGConfigNew();
|
||||
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
|
||||
|
||||
@@ -2026,8 +2022,6 @@ TEST(YogaTest, flex_direction_row_reverse_pos_end) {
|
||||
}
|
||||
|
||||
TEST(YogaTest, flex_direction_column_reverse_pos_top) {
|
||||
GTEST_SKIP();
|
||||
|
||||
const YGConfigRef config = YGConfigNew();
|
||||
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
|
||||
|
||||
@@ -2113,8 +2107,6 @@ TEST(YogaTest, flex_direction_column_reverse_pos_top) {
|
||||
}
|
||||
|
||||
TEST(YogaTest, flex_direction_column_reverse_pos_bottom) {
|
||||
GTEST_SKIP();
|
||||
|
||||
const YGConfigRef config = YGConfigNew();
|
||||
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
|
||||
|
||||
|
Reference in New Issue
Block a user